Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest reactstrap instead of react-bootstrap #4700

Closed
wants to merge 5 commits into from

Conversation

Brew-Brew
Copy link
Contributor

I thought it would be great to recommend Reactstrap for now, instead of react-bootstrap. :)


```sh
npm install --save react-bootstrap bootstrap@3
npm install bootstrap --save
npm install --save reactstrap react react-dom
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be one line and read:

npm install --save reactstrap bootstrap@4

```

Alternatively you may use `yarn`:

```sh
yarn add react-bootstrap bootstrap@3
yarn add bootstrap reactstrap react react-dom
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove react and react-dom, then make bootstrap -> bootstrap@4.

```

Import Bootstrap CSS and optionally Bootstrap theme CSS in the beginning of your ```src/index.js``` file:

```js
import 'bootstrap/dist/css/bootstrap.css';
import 'bootstrap/dist/css/bootstrap-theme.css';
import 'bootstrap/dist/css/bootstrap.min.css';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import 'bootstrap/dist/css/bootstrap.css';

we minify css ourselves

Copy link
Contributor Author

@Brew-Brew Brew-Brew Jun 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot create-react-app minify css :). I fixed readme as you reviewed, Thanks!

// Put any other imports below so that CSS from your
// components takes precedence over default styles.
```

Import required React Bootstrap components within ```src/App.js``` file or your custom component files:
Import required Reactstrap components within ```src/App.js``` file or your custom component files:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reactstrap

(lowercase please)

```

Now you are ready to use the imported React Bootstrap components within your component hierarchy defined in the render method. Here is an example [`App.js`](https://gist.githubusercontent.com/gaearon/85d8c067f6af1e56277c82d19fd4da7b/raw/6158dd991b67284e9fc8d70b9d973efe87659d72/App.js) redone using React Bootstrap.
Now you are ready to use the imported Reactstrap components within your component hierarchy defined in the render method. Here is an example [`App.js`](https://gist.githubusercontent.com/zx6658/d9f128cd57ca69e583ea2b5fea074238/raw/a56701c142d0c622eb6c20a457fbc01d708cb485/App.js) redone using Reactstrap.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reactstrap

(lowercase please)

@Brew-Brew
Copy link
Contributor Author

@Timer i fixed it! i'm honor to get your review :) Thanks!

@Timer
Copy link
Contributor

Timer commented Jun 29, 2018

It looks like you accidentally removed some sections. We still need that CSS import!
If you could add back those removed sections, that'd be awesome.

@Brew-Brew
Copy link
Contributor Author

@Timer i did it ! Thanks :)

@Timer
Copy link
Contributor

Timer commented Jun 29, 2018

Perfect!!

@Timer Timer changed the title Edit readme reactstrap example instead of react-bootstrap in Readme  Suggest reactstrap instead of react-bootstrap Jun 29, 2018
@Timer
Copy link
Contributor

Timer commented Jun 29, 2018

Oo crap, one last thing. You seemed to do this on master, can you please do it on next instead?

@Brew-Brew
Copy link
Contributor Author

@Timer Sure!

@Brew-Brew
Copy link
Contributor Author

Brew-Brew commented Jun 29, 2018

#4703 @Timer i did pr to next branch here!

@Brew-Brew Brew-Brew closed this Jun 29, 2018
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants