add gql file extension #4691
add gql file extension #4691
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
It was intentional at the time. It's odd to support two extensions for the same thing. Is it really that necessary? Why is it valuable? |
|
It was no huge value I think it's something that started getting adopted over time because people preferred to just write gql. It was the first one I tried when downloading v2 of react scripts, it's also on all the introductions and examples as another way to do it. Examples: I think it mostly came from the gql package and became an unofficial thing people started doing If not merged maybe add some note on the Readme.md when it has this part that only .graphql files are supported 👌 |
|
GQL was removed in favor of Macros, thanks! |
👋
I was testing the PR #3909 and noticed it only accepts .graphql files and since it's a very common practice to use .gql files for shorter typing I added support for those by changing the test for graphql files to the one here: https://github.com/apollographql/graphql-tag#webpack-preprocessing-with-graphql-tagloader
Also added a test for the gql extension and ran prettier.
Let me know any problems or if it's not something you don't plan to support