Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-scripts README for new service workers being disabled by default #3955

Conversation

jonathanchu
Copy link

This PR updates the react-scripts README for services workers now being disabled by default. It includes instructions on how to enable them and modifies the subsequent section to be consistent with the new defaults.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Timer
Copy link
Contributor

Timer commented Feb 2, 2018

Dupe of #3924, thanks for your contribution!

@Timer Timer closed this Feb 2, 2018
@jonathanchu
Copy link
Author

Whoops, sorry totally didn't see that. Thanks @Timer!

@jonathanchu jonathanchu deleted the update-readme-service-workers-disabled-by-default branch February 2, 2018 05:37
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants