-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force rebuild after npm install #349
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
/** | ||
* Copyright (c) 2015-present, Facebook, Inc. | ||
* All rights reserved. | ||
* | ||
* This source code is licensed under the BSD-style license found in the | ||
* LICENSE file in the root directory of this source tree. An additional grant | ||
* of patent rights can be found in the PATENTS file in the same directory. | ||
*/ | ||
|
||
// This Webpack plugin ensures `npm install <library>` forces a project rebuild. | ||
// We’re not sure why this isn't Webpack's default behavior. | ||
// See https://github.com/facebookincubator/create-react-app/issues/186. | ||
|
||
function WatchMissingNodeModulesPlugin(nodeModulesPath) { | ||
this.nodeModulesPath = nodeModulesPath; | ||
} | ||
|
||
WatchMissingNodeModulesPlugin.prototype.apply = function (compiler) { | ||
compiler.plugin('emit', (compilation, callback) => { | ||
var missingDeps = compilation.missingDependencies; | ||
var nodeModulesPath = this.nodeModulesPath; | ||
|
||
// If any missing files are expected to appear in node_modules... | ||
if (missingDeps.some(file => file.indexOf(nodeModulesPath) !== -1)) { | ||
// ...tell webpack to watch node_modules recursively until they appear. | ||
compilation.contextDependencies.push(nodeModulesPath); | ||
} | ||
|
||
callback(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Express middleware calls this There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Most webpack plugins I saw use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just trying to give more context, I don't particularly care :) |
||
}); | ||
} | ||
|
||
module.exports = WatchMissingNodeModulesPlugin; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the minimum node version we support have arrow functions support?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes