chore: Allow to install eslint-plugin-react ^7.1.0 to get rid of warnings on start

[FezVrasta]

This should allow people to install eslint-plugin-react 7.2.0 which gets rid of the following warnings when you run yarn start:

can't resolve reference #/definitions/basicConfig from id #
can't resolve reference #/definitions/basicConfigOrBoolean from id #
can't resolve reference #/definitions/basicConfigOrBoolean from id #

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[Timer]

What warnings are you talking about; could you please give me more context? These are development dependencies of a required package, so they should never be installed under normal use anyway.

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[FezVrasta]

So, when you start the app, you get the warnings reported in my first post.

The problem is that yarn (and probably npm) will install 7.1.0 instead of any newer version because this is the only version that matches the requirements of all the packages.

If you loosen the requirement here, the latest version will be installed and used by all the other packages of create-react-app as well.

❯ cat node_modules/eslint-plugin-react/package.json | grep version
  "version": "7.1.0",

If I put this in my package.json:

  "resolutions": {
    "eslint-plugin-react": "7.2.0"
  }

The warnings go away

[Timer]

I guess more appropriately, I cannot reproduce this.
A demo would be useful.

Are you using Yarn, npm? What version? What react-scripts version (I assume latest; or is this the monorepo)?

Once again, you're modifying a development dependency which should not affect the install tree (ever); did you mean to edit the package in react-scripts?

[FezVrasta]

Oh, yeah you are right, I should have edited the one in react-scripts.

The warnings comes out after you eject and thinker a bit with the app, but the base problem is that react-scripts requires an older version without any particular reason.

[Timer]

react-scripts strictly depends on pinned versions of packages to prevent accidental breaking changes in package releases -- a common occurrence in the tooling world.

I do not see us loosening this requirement as it's not clear to me how this benefits anything and how it couldn't be simply overridden when you eject (or how it causes this problem).

If there's a problem here, it sounds like it's more in-line with invalid configuration or a breaking change released under a non-major version (and then stemming from configuration in eslint-config-react-app).

[FezVrasta]

Can't we bump it to 7.2.0 then? It simply fixes this warning, can't be anything bad.

[Timer]

I would like to figure out the underlying cause before we update packages.

[FezVrasta]

More info about the warning:

• [eslint-config-airbnb] can't resolve reference airbnb/javascript#1488
• react/jsx-curly-spacing rule crashes ESLint 4.2.0 jsx-eslint/eslint-plugin-react#1290

[adam187]

@Timer @FezVrasta

I had similar issue.
In my case this warning did show when i was linting app with my own eslint config.
my external config have [email protected] as dependency but because react-scripts requires [email protected] this was version that npm installed.

adding

"resolutions": {
    "eslint-plugin-react": "7.4.0"
  }

to my package.json solved issue.

But i didn't get this warring while starting server via yarn start

[react-scripts-dangerous]

Hello! I'm a bot that helps facilitate testing pull requests.

Your pull request (commit d68fa77) has been released on npm for testing purposes.

npm i [email protected]
# or
yarn add [email protected]
# or
create-react-app [email protected] folder/

Note that the package has not been reviewed or vetted by the maintainers. Only install it at your own risk!

Thanks for your contribution!

[gaearon]

We will bump this plugin in the next major. It's not supported to install and use arbitrary versions of ESLint plugins in a non-ejected project.