Upgrade to svgr 6 #11780
Open
Upgrade to svgr 6 #11780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmckeb
reviewed
Dec 17, 2021
packages/react-scripts/package.json
Outdated
| @@ -77,6 +76,7 @@ | |||
| "workbox-webpack-plugin": "^6.4.1" | |||
| }, | |||
| "devDependencies": { | |||
| "@svgr/webpack": "^6.1.2", | |||
There was a problem hiding this comment.
This would still be a dependency of react-scripts, as we want it to install when users install react-scripts :)
There was a problem hiding this comment.
You are right. Put it there by inertia.
Closed
|
Nice! Looks like this needs a rebase on |
Ref https://github.com/gregberge/svgr/releases/tag/v6.0.0 This release bumped svgo internally which has a lot of fixes and less dependencies.
TrySound
force-pushed
the
upgrade-svgr-6
branch
from
9631d46
to
f46435b
Compare
4 tasks
|
@iansu We are waiting on this pull request to fix nth check vulnerability. Can you please help us with ETA on this one.? |
|
It has been two months |
|
There are two PRs with update to newer version: |
|
Any news? |
|
did it solved ?? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref https://github.com/gregberge/svgr/releases/tag/v6.0.0
This release bumped svgo internally which has a lot of fixes and less
dependencies.