Make build fail on ESLint warnings if running CI #1162
Conversation
| @@ -184,7 +184,9 @@ module.exports = { | |||
| // TODO: consider separate config for production, | |||
| // e.g. to enable no-console and no-debugger only in production. | |||
| configFile: path.join(__dirname, '../.eslintrc'), | |||
| useEslintrc: false | |||
| useEslintrc: false, | |||
| failOnWarning: !!process.env.CI, | |||
There was a problem hiding this comment.
We need to make sure this works after ejecting too.
So // @remove-on-eject-begin needs to move inside eslint config object.
|
The stack trace is useless here and the error message is not very good.
Is there anything we can do to improve them? Ideally I'd like to remove |
|
Seems like all of this formatting is directly baked into webpack. The short message after I agree though, the stacktrace is pretty unfortunate in this case and can be confusing. |
It is, but we filter that in I don't mind dirty hacks as long as they're inside |
|
Well, we could dissect the error here and just pretty-print it. I'll have a better look at this later. |
|
Another thing I'm not very happy with is that now Babel build errors don't show the source:
They used to have the code frame:
I'm not sure if this is the right direction. Maybe we should just manually call ESLint itself and remove |
|
I played around with it and indeed Closing this PR in favour of a better solution. |
( Related to previous pull request #944 and issue #1150 that followed. )
This pull request reverts behaviour in
buildscript and moves the responsibility toeslint-loader.As a bonus, this change makes the build fail almost immediately compared to previous solution.
cc @excitement-engineer