Allow relative $PUBLIC_URL in dev mode #10503
Conversation
nhooyr
requested review from
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
|
Hi @nhooyr! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
As long as client side routing isn't used, a relative $PUBLIC_URL should work correctly in both development and production. There's no reason it should be limited to production. Closes facebook#8623 Also see coder/code-server#2565
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
|
Is there any update on this? I need to use relative paths in dev mode and it's being quite a nightmare (see webpack/webpack#16425) |
|
I'm no longer interested in persuing this. |
As long as client side routing isn't used, a relative $PUBLIC_URL should
work correctly in both development and production.
There's no reason it should be limited to production.
Closes #8623
Also see coder/code-server#2565