Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlock deps #10135

Closed
wants to merge 1 commit into from
Closed

Unlock deps #10135

wants to merge 1 commit into from

Conversation

cesine
Copy link

@cesine cesine commented Nov 24, 2020

We found react-dev-utils was introducing multiple versions of other libs we consume such as @babel/code-frame due to the locked deps.

Excerpt from our yarn.lock:

react-dev-utils@^11.0.0:
  version "11.0.1"
  resolved "http://artifactory.shuttercorp.net/artifactory/api/npm/npm-composite/react-dev-utils/-/react-dev-utils-11.0.1.tgz#30106c2055acfd6b047d2dc478a85c356e66fe45"
  integrity sha1-MBBsIFWs/WsEfS3EeKhcNW5m/kU=
  dependencies:
    "@babel/code-frame" "7.10.4"
    address "1.1.2"
    browserslist "4.14.2"
    chalk "2.4.2"
    cross-spawn "7.0.3"
    detect-port-alt "1.1.6"
    escape-string-regexp "2.0.0"
    filesize "6.1.0"
    find-up "4.1.0"
    fork-ts-checker-webpack-plugin "4.1.6"
    global-modules "2.0.0"
    globby "11.0.1"
    gzip-size "5.1.1"
    immer "7.0.9"
    is-root "2.1.0"
    loader-utils "2.0.0"
    open "^7.0.2"
    pkg-up "3.1.0"
    prompts "2.4.0"
    react-error-overlay "^6.0.8"
    recursive-readdir "2.2.2"
    shell-quote "1.7.2"
    strip-ansi "6.0.0"
    text-table "0.2.0"

I looked for why this might be the case, it seems unintentional. normally I would also check in the yarn.lock when using unlocked deps, but #7765 (comment) asks that it be gitignored

ensure that our CI installs the latest versions of packages to discover potential issues our users may encounter.

  • [ ] run this PR in CI to find out if it does fail with latest deps
    Other PRs are failing too, so CI cant be used to measure this PR

Screen Shot 2020-11-23 at 10 41 19 PM

And locally

$ ./tasks/e2e-simple.sh
~/create-react-app/packages/react-error-overlay/src/__tests__/extract-source-map.js
  28:5  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect

~/create-react-app/packages/react-error-overlay/src/__tests__/get-source-map.js
  58:5  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect
  59:5  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect

~/create-react-app/packages/react-error-overlay/src/__tests__/parser/generic.js
  15:5  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect
  16:5  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect
  25:5  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect
  26:5  error  Avoid calling `expect` conditionally`  jest/no-conditional-expect

✖ 7 problems (7 errors, 0 warnings)

@stale
Copy link

stale bot commented Dec 25, 2020

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale
Copy link

stale bot commented Jan 9, 2022

This pull request has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue. Thank you for your contribution!

@stale stale bot closed this Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants