-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Jest 19 #1604
Comments
I'm happy to do the update |
Sounds good! |
Any news on this? |
You can help fixing them. 😉 For the reference: |
Hi -- it looks like jest is pretty much broken with the current CRA release. |
Hey! You don't need to install any jest packages for it to work with CRA. Please uninstall all jest related packages and try npm test again. (this all assumes you haven't ejected) |
Hi -- I haven't ejected, so that should be okay. |
Bingo! I must have tried a manual install of jest (I don't remember doing it, but I must have) and that screwed things up -- thankyou so much! :) |
No worries! If you remember why you tried to do it (e.g. a confusing guide) let us know! |
I think I just assumed I needed to add it explicitly -- so more a case of not reading the guide properly, as opposed to being confused by it. |
I'm getting this as well in react-storybook: #1604 (comment) In our case we're using lerna with hoisting and somehow this is causing problems in a create-react-app + storybook example:
Full log here: https://travis-ci.org/storybooks/storybook/builds/226783695#L2102 For now I have disabled lerna hoisting and it appears this resolves the issue. |
Please help beta test the new version that includes this change! |
Seems like a pretty sweet release: http://facebook.github.io/jest/blog/2017/02/21/jest-19-immersive-watch-mode-test-platform-improvements.html.
This is a breaking change so targeting 0.10. A PR to update is welcome.
Also worth keeping an eye on jestjs/jest#2957.
The text was updated successfully, but these errors were encountered: