Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Recognize NDK version 19 #2189

Closed
wants to merge 1 commit into from
Closed

Conversation

wjmelements
Copy link

Changes

Each new NDK version will break under this scheme.
This fixes the error Unknown ndk version: 19.0.5232133.
Please develop a long-term solution.
Reviewer @ttsugriy

@wjmelements
Copy link
Author

This approach is similar to #1511

@wjmelements
Copy link
Author

Please either merge this or #2190

@ttsugriy
Copy link
Contributor

ttsugriy commented Feb 6, 2019

sorry, I no longer work on Buck, but I'm sure someone from the Buck team, like @styurin will take a look soon.

@wjmelements
Copy link
Author

Another thing I noticed is that NDK 19 removed the -gcc scripts in ndk-bundle/toolchains/arm-linux-androideabi-4.9/prebuilt/darwin-x86_64/bin/ (android/ndk#862).

@wjmelements wjmelements changed the title Support NDK 19 Recognize NDK version 19 Feb 6, 2019
@wjmelements
Copy link
Author

Thus NDK 19 is not fully supported by this PR.

The error is

~/Library/Android/sdk/ndk-bundle/toolchains/arm-linux-androideabi-4.9/prebuilt/darwin-x86_64/bin/arm-linux-androideabi-gcc doesn't exist.

The files in that directory are:

arm-linux-androideabi-addr2line arm-linux-androideabi-dwp       arm-linux-androideabi-ld.bfd    arm-linux-androideabi-objdump   arm-linux-androideabi-strings
arm-linux-androideabi-ar        arm-linux-androideabi-elfedit   arm-linux-androideabi-ld.gold   arm-linux-androideabi-ranlib    arm-linux-androideabi-strip
arm-linux-androideabi-as        arm-linux-androideabi-gprof     arm-linux-androideabi-nm        arm-linux-androideabi-readelf
arm-linux-androideabi-c++filt   arm-linux-androideabi-ld        arm-linux-androideabi-objcopy   arm-linux-androideabi-size

I am not sure how to best fix this breakage.

@styurin
Copy link

styurin commented Feb 7, 2019

Adding support for the next version NDK is not simply bumping the version, there are usually major changes which needs to reflected before enabling that support.

@wjmelements wjmelements closed this Feb 7, 2019
@wjmelements
Copy link
Author

I documented some of the incompatibility in #2191. Closed because I do not have the time to investigate this myself.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants