Enable running all tests to completion even if one python version failed #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Pull Request Test Coverage Report for Build 697672057
💛 - Coveralls |
|
@macisamuele has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@macisamuele merged this pull request in f42e0e9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Ensure that we do run all the tests (platforms/python-versions) and that we don't immediately stop if one has failed.
This is a follow-up from #292
Why:
In case of test failures is extremely interesting to have information about "is this failure a genuine bug or is an issue with a single python version?".
How:
Ensure that github workflow is correctly defined. Doc in here
Risks:
n/a
Checklist: