Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strict mock return type validation #153

Merged
merged 2 commits into from
Apr 9, 2020
Merged

Strict mock return type validation #153

merged 2 commits into from
Apr 9, 2020

Conversation

fabriziocucci
Copy link

Closes #150.

@fabriziocucci fabriziocucci added this to the Type Checking milestone Apr 9, 2020
@fabriziocucci fabriziocucci requested a review from fornellas April 9, 2020 14:00
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Apr 9, 2020
fornellas
fornellas reviewed Apr 9, 2020
View reviewed changes
testslide/lib.py Outdated Show resolved Hide resolved
@fabriziocucci fabriziocucci force-pushed the strict_mock_return_type_validation branch from 53c3b45 to a5aa062 Compare April 9, 2020 14:26
@fornellas fornellas force-pushed the strict_mock_return_type_validation branch from a5aa062 to 286a0a7 Compare April 9, 2020 15:38
@fabriziocucci fabriziocucci force-pushed the strict_mock_return_type_validation branch from 286a0a7 to a5aa062 Compare April 9, 2020 15:46
@fabriziocucci fabriziocucci force-pushed the strict_mock_return_type_validation branch from a5aa062 to 9d93382 Compare April 9, 2020 16:10
@fornellas fornellas merged commit ae9b805 into master Apr 9, 2020
@fornellas fornellas deleted the strict_mock_return_type_validation branch April 9, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fornellas fornellas fornellas left review comments

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
Type Checking
Development

Successfully merging this pull request may close these issues.

Implement StrictMock method return type validation
3 participants
@fabriziocucci @fornellas @facebook-github-bot