Skip to content

Commit

Permalink
Remove isort from Makefile to make OSS CI pass again, it was (#368)
Browse files Browse the repository at this point in the history
Summary:
reformatted internally with black, and that has priority

- [] Added tests, if you've added code that should be tested
- [ ] Updated the documentation, if you've changed APIs
- [ ] Ensured the test suite passes
- [X] Made sure your code lints
- [X] Completed the Contributor License Agreement ("CLA")

Pull Request resolved: #368

Reviewed By: jermenkoo

Differential Revision: D61269377

Pulled By: deathowl

fbshipit-source-id: 402de2fa4c9052de955c5c53c22cf278c1dfc243
  • Loading branch information
deathowl authored and facebook-github-bot committed Aug 14, 2024
1 parent d277f81 commit 793a672
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 13 deletions.
12 changes: 0 additions & 12 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -122,16 +122,6 @@ black: venv
@printf "${TERM_BRIGHT}BLACK ${ALL_SRCS}\n${TERM_NONE}"
${Q} ${CURDIR}/venv/bin/black --check --diff $(ALL_SRCS) || { echo "Formatting errors found, try running 'make format'."; exit 1; }

.PHONY: isort
isort: venv
@printf "${TERM_BRIGHT}ISORT ${ALL_SRCS}\n${TERM_NONE}"
${Q} ${CURDIR}/venv/bin/isort --check-only --profile black $(ALL_SRCS) || { echo "Formatting errors found, try running 'make format'."; exit 1; }

.PHONY: format_isort
format_isort: venv
@printf "${TERM_BRIGHT}FORMAT PYFMT ${ALL_SRCS}\n${TERM_NONE}"
${Q} ${CURDIR}/venv/bin/isort --profile black $(ALL_SRCS)

.PHONY: format_black
format_black: venv
@printf "${TERM_BRIGHT}FORMAT BLACK ${ALL_SRCS}\n${TERM_NONE}"
Expand All @@ -144,13 +134,11 @@ tests: \
pytest_tests \
mypy \
flake8 \
isort \
black \
check-copyright

.PHONY: format
format: \
format_isort \
format_black
@true
##
Expand Down
1 change: 0 additions & 1 deletion requirements-dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ black
coverage
coveralls
flake8
isort~=5.1
mypy==1.2
ipython
sphinx
Expand Down

0 comments on commit 793a672

Please sign in to comment.