Skip to content

Commit

Permalink
Include reason for SO load fail in message
Browse files Browse the repository at this point in the history
Summary: We found a crash in prod attributed to SO load failure (Logview: https://fburl.com/logview/hrqnb5qs). The stack trace point to the two different reasons, SoSource.LOAD_RESULT_NOT_FOUND and SoSource.LOAD_RESULT_CORRUPTED_LIB_FILE https://fburl.com/diffusion/vrk1edr4. This diff just simply includes the reason in the error message.

Reviewed By: jdlehman

Differential Revision: D18044716

fbshipit-source-id: a4222afb879e3532646df71ed8380409e3b7caf7
  • Loading branch information
Lynn Cherngchaosil authored and facebook-github-bot committed Oct 22, 2019
1 parent cdd144a commit 4213ab1
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions java/com/facebook/soloader/SoLoader.java
Original file line number Diff line number Diff line change
Expand Up @@ -786,6 +786,7 @@ private static void doLoadLibraryBySoName(
message += " caused by: " + cause;
error.printStackTrace();
}
message += " result: " + result;
Log.e(TAG, message);
throw new UnsatisfiedLinkError(message);
}
Expand Down

0 comments on commit 4213ab1

Please sign in to comment.