Skip to content

Commit

Permalink
Fix all the uses of node.in_shard?(x) where x is a multiple of 5
Browse files Browse the repository at this point in the history
Differential Revision: D49900503

fbshipit-source-id: 6372c56d38d161a8a819fc3d0a0698b8ee423153
  • Loading branch information
Olivier Raginel authored and facebook-github-bot committed May 28, 2024
1 parent db08c66 commit 48a5c78
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions itchef/cookbooks/fb_helpers/spec/node_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,9 @@
expect(node.in_shard?(67)).to eq(true)
end
it 'should return false if we are not in shard' do
expect(node.in_shard?(65)).to eq(false)
expect(node.in_shard?(64)).to eq(false)
# Should remain false on second calling
expect(node.in_shard?(65)).to eq(false)
expect(node.in_shard?(64)).to eq(false)
end
it 'should retain legacy overflow behaviour' do
# avoid using literals so linters don't fire
Expand Down

0 comments on commit 48a5c78

Please sign in to comment.