Consolidate compilation conditionals around types #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By writing a static method `GetTypeInfo` that just returns the passed in type when `SIMPLE_JSON_TYPEINFO == false` we can use the same code for both values of the conditional compilation constant `SIMPLE_JSON_TYPEINFO`.
prabirshrestha
added a commit
that referenced
this pull request
Sep 8, 2013
Consolidate compilation conditionals around types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By writing a static method
GetTypeInfothat just returns the passed in type whenSIMPLE_JSON_TYPEINFO == falsewe can use the same code for both values of the conditional compilation constantSIMPLE_JSON_TYPEINFO.Normally this would be done with an extension method but we can't use those in this project. :)