This repository has been archived by the owner on Sep 1, 2021. It is now read-only.
Expose garbage collector to Electron when it was exposed in Node #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to the new WeakRef feature it is possible to test for memory leaks when exposing the garbage collector to Node. With this pull request the garbage collector is also exposed to Electron when it was exposed to Node so the same tests which works with Node runner can also work with electron runner.
This is a very small change, it doesn't change any behavior except exposing the garbage collector to Electron and even this is only done when the user already exposed the garbage collector to Node. So for the standard usage this small change doesn't do anything. And for those who expose the garbage collector to Node this change is very useful for writing unit tests running in Electron which can check for memory leaks.