-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MakeViewVariableOptionalSolution to disallow stream wrappers and files that do not end in .blade.php #334
Fix MakeViewVariableOptionalSolution to disallow stream wrappers and files that do not end in .blade.php #334
Conversation
Thanks! |
CVE-2021-3129 was assigned to this PR. |
Can we get this patch committed to the 1.16.x branch? |
I would love to create a PR myself with the changes for the 1.16.4 release, but unfortunately everything lives in the same branch (both 2.x and 1.x versions of this package). It would be fantastic if there was a way to push these changes to a 1.16.5 tag, so all the folks still using Laravel 6 and facade/ignition 1.x could benefit of this change.
|
…files that do not end in .blade.php This is already fixed in 2.5.2, See facade#334 I could not update to 2.5.2 due to some dependent package required php 7.3, currently clients site is running in php 7.2 On branch 2.4.1-branch Changes to be committed: modified: src/Solutions/MakeViewVariableOptionalSolution.php
The vulnerability in `facade/ignition` is falsely reported for version 2.4.2. It has been fixed in facade/ignition#334 for 2.5.x, and in facade/ignition#356 for 2.4.x.
The vulnerability in `facade/ignition` is falsely reported for version 2.4.2. It has been fixed in facade/ignition#334 for 2.5.x, and in facade/ignition#356 for 2.4.x. Fixes FriendsOfPHP#543
…files that do not end in .blade.php This is already fixed in 2.5.2, See facade/ignition#334 I could not update to 2.5.2 due to some dependent package required php 7.3, currently clients site is running in php 7.2 On branch 2.4.1-branch Changes to be committed: modified: src/Solutions/MakeViewVariableOptionalSolution.php
…files that do not end in .blade.php This is already fixed in 2.5.2, See facade/ignition#334 I could not update to 2.5.2 due to some dependent package required php 7.3, currently clients site is running in php 7.2 On branch 2.4.1-branch Changes to be committed: modified: src/Solutions/MakeViewVariableOptionalSolution.php
Hello, as discussed by email, this fixes a serious vulnerability.
Hopefully my code is OK-ish.