Make both solution providers pass in their custom title

facade · Sep 4, 2019 · 1d56350 · 1d56350
1 parent 6e32bbd
commit 1d56350
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 10 deletions.
diff --git a/src/SolutionProviders/MissingColumnSolutionProvider.php b/src/SolutionProviders/MissingColumnSolutionProvider.php
@@ -30,8 +30,6 @@ protected function isBadTableErrorCode($code): bool
 
     public function getSolutions(Throwable $throwable): array
     {
-        $solution = new RunMigrationsSolution('A column was not found');
-
-        return [$solution];
+        return [new RunMigrationsSolution('A column was not found')];
     }
 }
diff --git a/src/SolutionProviders/TableNotFoundSolutionProvider.php b/src/SolutionProviders/TableNotFoundSolutionProvider.php
@@ -30,6 +30,6 @@ protected function isBadTableErrorCode($code): bool
 
     public function getSolutions(Throwable $throwable): array
     {
-        return [new RunMigrationsSolution()];
+        return [new RunMigrationsSolution('A table was not found')];
     }
 }
diff --git a/src/Solutions/RunMigrationsSolution.php b/src/Solutions/RunMigrationsSolution.php
@@ -9,18 +9,14 @@ class RunMigrationsSolution implements RunnableSolution
 {
     private $customTitle;
 
-    public function __construct($customTitle = null)
+    public function __construct($customTitle = '')
     {
         $this->customTitle = $customTitle;
     }
 
     public function getSolutionTitle(): string
     {
-        if (isset($this->customTitle)) {
-            return $this->customTitle;
-        }
-
-        return 'A table was not found';
+        return $this->customTitle;
     }
 
     public function getSolutionDescription(): string