Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update samples and templates #814

Merged
merged 30 commits into from
Nov 20, 2020
Merged

Update samples and templates #814

merged 30 commits into from
Nov 20, 2020

Conversation

TimLariviere
Copy link
Member

@TimLariviere TimLariviere commented Nov 14, 2020 •
edited
Loading

Update the samples to target Android 11, as well as the templates.

Things to do:

  • Re-enable Maps sample in AllControls

  • Ensure all samples fully work

  • Ensure templates work as expected on both macOS and Windows with the latest IDEs updates

  • Add System.Buffers to templates

  • Add System.Buffers to samples

  • Update documentation

  • Ensure F# 5 can be used (Partial support)

    • Visual Studio (Windows) 16.8: OK
    • Visual Studio Mac 8.8 (Stable): Not supported at all
    • Visual Studio Mac 8.9 (Preview): Partial support (can build and run, but no IDE support for new syntax for the moment)

@TimLariviere
Copy link
Member Author

/azp run full build

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@SergejDK
Copy link
Collaborator

@TimLariviere what is wrong with fabulousweather?

@TimLariviere
Copy link
Member Author

@SergejDK It was complaining that Xamarin.Forms.targets was imported 2 times when it was not. I got frustrated after fighting with it for 1 hour. 😅

I'll readd it after I'm done with the rest.

@TimLariviere
Copy link
Member Author

/azp run full build

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@SergejDK
Copy link
Collaborator

@TimLariviere does this maybe have something to do with the other issue and android? maybe this is a bug, too from Xamarin.Android and the tooling?
Do you still have the older VS version installed and can check this ? Looks similar to me...

@TimLariviere
Copy link
Member Author

I don't think it's linked to the issue with VS.
I'm working on macOS with the latest versions of VS Mac and Rider.

I think it's due to an invalid state in the Fabulous solution that forces the IDEs to load the FabulousWeather project 2 times.

@TimLariviere
Copy link
Member Author

/azp run full build

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@TimLariviere
Copy link
Member Author

/azp run full build

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@TimLariviere
Copy link
Member Author

/azp run full build

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@TimLariviere
Copy link
Member Author

/azp run full build

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@TimLariviere
Copy link
Member Author

The hosted build agents are not yet updated to build .NET 5.0 apps...
Apparently, they will be updated next week.
https://developercommunity.visualstudio.com/content/problem/1255480/building-net-50-in-a-pipeline-doesnt-work.html

I will revert that change in the meantime.

@TimLariviere
Copy link
Member Author

/azp run full build

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@TimLariviere
Copy link
Member Author

/azp run full build

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@TimLariviere TimLariviere changed the title Upgrade to Android 11 Update samples Nov 18, 2020
@TimLariviere TimLariviere changed the title Update samples Update samples and templates Nov 18, 2020
@TimLariviere
Copy link
Member Author

/azp run full build

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@TimLariviere
Copy link
Member Author

/azp run full build

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@TimLariviere TimLariviere marked this pull request as ready for review November 20, 2020 22:09
@TimLariviere TimLariviere merged commit 0d485a8 into fabulous-dev:master Nov 20, 2020
@TimLariviere TimLariviere deleted the upgrade-android-11 branch November 20, 2020 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TimLariviere @SergejDK