Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extraAttributes support #780

Closed
wants to merge 1 commit into from

Conversation

Dolfik1
Copy link

@Dolfik1 Dolfik1 commented Jul 30, 2020

At this moment we can add extra attributes via WithAttribute function. This way is very slow because we duplicate element on each WithAttribute call. This PR adds extraAttributes key to all views:

View.Label(
  text = "Hello, world!",
  extraAttributes = [
    key "helloworld"
    row 0
    column 1
  ]
)

extraAttributes preallocates space in beginning of array and call WithAttribute function for each value in extraAttributes.

@vshapenko vshapenko mentioned this pull request Sep 23, 2020
@SergejDK
Copy link
Collaborator

I discussed this with @TimLariviere and this will be available in Fabulous v2 which he currently works on.

I will close this PR because this is planned in v2 with a new way for handling this.

@SergejDK SergejDK closed this Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants