-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AndroidX for Fabulous.XamarinForms.Templates #750
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much! That's some tedious work you did. Much appreciated.
Did you noticed some issues when using AndroidX and Xamarin.Forms?
Last time I tried to migrate the Fabimals sample, it was crashing because of a null reference exception in Shell.
Fabulous.XamarinForms/templates/content/blank/NewApp.Android/NewApp.Android.fsproj
Outdated
Show resolved
Hide resolved
Fabulous.XamarinForms/templates/content/blank/.template.config/template.json
Show resolved
Hide resolved
Fabulous.XamarinForms/templates/content/blank/NewApp.Android/NewApp.Android.fsproj
Show resolved
Hide resolved
I guess the build issue is linked to the missing |
I don't use Shell, and I haven't noticed anything wrong with my app yet. |
Why is Mac build failing? |
From the build logs:
|
/azp run full build |
Azure Pipelines successfully started running 1 pipeline(s). |
I can't figure out why this is failing. The package list should be correct. |
I missed that the import of NuGet.targets was removed. So Android weren't restoring its packages. |
/azp run full build |
Commenter does not have sufficient privileges for PR 750 in repo fsprojects/Fabulous |
... |
Yeah, sorry for that. Azure DevOps is restrictive on that. |
/azp run full build |
Azure Pipelines successfully started running 1 pipeline(s). |
Hmm. Is it because MSBuild picks the wrong version of the Android Build tools?
|
Should be. The template executes fine locally. |
It doesn't seem to be that. Let's try bumping Mono to the latest version. |
@TimLariviere Can you verify that the template executes successfully locally? It does on my side. |
I have indeed the same issue locally. I'm investigating why. |
/azp run full build |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run full build |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run full build |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run full build |
Azure Pipelines successfully started running 1 pipeline(s). |
Ok. Seems like it was an issue with the NuGet restore process. |
/azp run full build |
Azure Pipelines successfully started running 1 pipeline(s). |
🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the new templates with Visual Studio, Visual Studio for Mac and JetBrains Rider (macOS).
Everything works as expected.
Good job!
/azp run full build |
Azure Pipelines successfully started running 1 pipeline(s). |
The pull request I mentioned at dotnet/maui#115 (comment).