Update dependencies in all projects and templates #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially the groundwork for #682.
Updated Paket to support
Android 10so we can upgrade our templates to benefit from AndroidX packagesSimplified our dependencies files (
Packages.targetandpaket.dependencies) by removing unneeded packages and unpinning some versionsUpdated versions where possible (still targeting XF 4.4 here)
Segregated "internal" and "external" dependencies in
Packages.targetI tried to put a clear distinction between "internal" and "external" dependencies.
Internal dependencies are NuGet packages the various projects, inside the Fabulous repository, use in order to compile and run but aren't showing as requirements in the users projects when taking a reference to one of our NuGet packages (e.g.
FSharp.Core-- users should be free to use the version they prefer within reasons).External dependencies are dependencies that will be required to the users when taking a reference to one of our NuGet packages. (e.g.
Xamarin.Forms)The main idea is that internal dependencies can target the latest version available, since it won't affect users.
External dependencies should always target the lowest compatible major version (e.g.
Xamarin.Formsshould be 4.4.0.991265 - lowest version in the 4.4.0 bracket - even if a newer 4.4.0.991864 is available) to not force users to target a potentially bugging new version when an older one works perfectly.