-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More modular AllControls sample #677
More modular AllControls sample #677
Conversation
@TimLariviere I'll take a look on what exactly you did in the next days. |
Finished moving samples away from the big file. :) |
@TimLariviere Tested on:
Maybe one more thing - we should show the control in die videomanagerextensions in this example else the sound keeps on playing which is kinda annoying. |
@SergejDK Thanks for the feedback!
Do you have any suggestion how we can make this part easier to understand?
Yes, I noticed this as well. I wasn't expecting Android/iOS to allow having a Shell/NavigationPage inside another NavigationPage but it worked. Though macOS doesn't allow this.
Noticed that as well. |
I just think that a little code documentation is enough - just did not worked a lot with f# the last weeks.
This should not be to difficult - maybe seperate issue |
I'm reworking the AllControls sample to make it easier to read a specific sample (e.g. How to use SkiaSharp?) and as well as make it easier to add new samples to it.
The idea is to add have distinct files and register them in the Samples.fs file, so the app will automatically pick them up.
Currently moved SkiaSharp, OxyPlot and Maps
@SergejDK Let me know what you think of it