XF Upgrade 4.4 #644

SergejDK · 2019-12-18T09:35:53Z

fix #641

TODO:

SergejDK · 2019-12-18T14:28:08Z

@TimLariviere
Should I add the new Views to AllControls ?

TimLariviere · 2019-12-18T17:47:16Z

Should I add the new Views to AllControls ?

Yes, please.

TimLariviere · 2019-12-18T17:56:55Z

Seems like there's a new LinearItemsLayout value like you added in #614: CarouselVertical
https://docs.microsoft.com/en-us/xamarin/xamarin-forms/release-notes/4.4/4.4.0-api#type-changed-xamarinformslinearitemslayout

TimLariviere

Great job so far!
I've added a few remarks on what's missing or what can prove challenging to correctly support.

Fabulous.XamarinForms/src/Fabulous.XamarinForms/Xamarin.Forms.Core.json

SergejDK · 2019-12-18T19:07:58Z

@TimLariviere
Good points :)

~~I see that we have an CustomEntryCell where the Text property and the textchanged event is used. Should we remove those parts? Is there even a need for a customEntryCell anylonger?~~

EDIT:
~~It is needed because there the textchangedevent is handled. But I think we can remove the two not used parts.~~

Just saw that it is Cell and not normal Entry....

TimLariviere · 2019-12-18T19:16:55Z

I see that we have an CustomEntryCell where the Text property and the textchanged event is used. Should we remove those parts? Is there even a need for a customEntryCell anylonger?

Yes, we need to keep it.
EntryCell doesn't inherit from InputView so it declares its own properties and events.
We had to write a CustomEntryCell because EntryCell only provide an overridable OnTextChanged instead of an event that we need.

SergejDK · 2019-12-18T20:16:46Z

@TimLariviere
I was taking a look on how to use IndicatorView and somehow I think we do not need to use ItemsSource and IndicatorTemplate.

https://docs.microsoft.com/en-us/xamarin/xamarin-forms/user-interface/indicatorview

Normally the method ItemsSourceBy is used with a reference to a CarouselView.

What do you think about exposing this function as a event and accept a ViewRef as in Input?

TimLariviere · 2019-12-19T19:16:02Z

What do you think about exposing this function as a event and accept a ViewRef as in Input?

Could you explain a bit more why you see it as an event?
But I agree that ViewRef<CarouselView> seems our best option, even though I'm not a fan...

SergejDK · 2019-12-19T22:59:45Z

@TimLariviere
did it as an property - don't know why I was thinking about events ....

One thing that I caught was that using a ViewRef for CarouselView needs a let carouselViewRef = ViewRef<CustomCarouselView> instead of ViewRef<CarouselView>. Maybe we should look at this ?

I think I need to rewrite the updateIndicatorViewRef function so it is possible to have params like prevValueOpt: ViewRef<'T> voption instead of a specific type. - What do you think?

After all this is working with the ViewRef idea.

SergejDK · 2019-12-20T13:36:29Z

@TimLariviere
SwipeView is working fine and IndicatorView, too :) Samples are included in AllControls.

SergejDK · 2020-01-02T19:49:40Z

@TimLariviere
do you have a better solution for CarouselVerticalItemsLayout than I currently have?

TimLariviere

Sorry for the late reply. I needed some time off.
I'm slowly getting back on this PR. Here's a few things I found.

TimLariviere · 2020-02-02T14:30:50Z

Fabulous.XamarinForms/src/Fabulous.XamarinForms.Core/ViewUpdaters.fs

+        | ValueSome prevValue, ValueSome currValue when prevValue = currValue -> ()
+        | ValueNone, ValueNone -> ()
+        | _, ValueSome currValue -> Shell.SetNavBarHasShadow(target, currValue)
+        | ValueSome _, ValueNone -> Shell.SetNavBarHasShadow(target, true)


The default value of NavBarHasShadow is dependent of the platform. If it's Android, it is true, false otherwise.
See https://github.com/xamarin/Xamarin.Forms/blob/1ae8fb1cd53f8cc0584249f824e457ce2a091354/Xamarin.Forms.Core/Shell/Shell.cs#L37

Fabulous.XamarinForms/src/Fabulous.XamarinForms.Core/ViewUpdaters.fs

TimLariviere · 2020-02-02T14:35:53Z

Fabulous.XamarinForms/src/Fabulous.XamarinForms.Core/ViewUpdaters.fs

+            match currValue.TryValue with
+            | Some v -> IndicatorView.SetItemsSourceBy(target, v)
+            | None -> ()


Maybe we should set the ItemsSource to null in the case the ref is invalid, instead of doing nothing and keeping a previous state no longer wanted?

TimLariviere · 2020-02-02T14:36:40Z

Fabulous.XamarinForms/src/Fabulous.XamarinForms/Xamarin.Forms.Core.json

+        {
+          "source": null,
+          "name": "ShellNavBarHasShadow",
+          "defaultValue": "true",


Same as above. Default value is dependent of the platform.

TimLariviere · 2020-02-02T14:54:34Z

do you have a better solution for CarouselVerticalItemsLayout than I currently have?

@SergejDK There doesn't seem to be a better way. Relying directly on LinearItemsLayout.CarouselLayout would lead to accidental overriding of the value since it's a class.

Fabulous.XamarinForms/src/Fabulous.XamarinForms.Core/ViewHelpers.fs

TimLariviere

Thanks!

magnushammar · 2020-02-11T07:19:00Z

Awesome work thanks!

I just compiled an app with it now and my SwipeItems are showing as expected.

Sergej Dick added 3 commits December 18, 2019 10:34

first part

3d9c394

second part

1003ac3

added events

081e587

TimLariviere reviewed Dec 18, 2019

View reviewed changes

some fixes; indicatorview and swipeitems open

c9dc43e

first part indicatorview

6ea831e

swipeview added with example

cb48bb2

SergejDK marked this pull request as ready for review December 29, 2019 21:04

CarouselVerticalItemsLayout

7ec8c92

SergejDK mentioned this pull request Jan 3, 2020

Problem with Xamarin.Forms 4.4 #649

Closed

TimLariviere requested changes Feb 2, 2020

View reviewed changes

requested changes

86900d2

TimLariviere reviewed Feb 3, 2020

View reviewed changes

Fabulous.XamarinForms/src/Fabulous.XamarinForms.Core/ViewHelpers.fs Outdated Show resolved Hide resolved

SergejDK added 2 commits February 3, 2020 20:01

removed defaultvalue

4a0ba36

added defaultvalue again

0d7da45

SergejDK changed the title ~~WIP: XF Upgrade 4.4~~ XF Upgrade 4.4 Feb 3, 2020

changes

6ece43d

TimLariviere approved these changes Feb 10, 2020

View reviewed changes

TimLariviere merged commit a5c2051 into fabulous-dev:master Feb 10, 2020

SergejDK deleted the 44 branch February 13, 2020 14:59

TimLariviere mentioned this pull request Feb 19, 2020

Release notes for v0.52 #674

Merged

Happypig375 mentioned this pull request Mar 1, 2020

Xamarin.Forms 4.5 #682

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

XF Upgrade 4.4 #644

XF Upgrade 4.4 #644

SergejDK commented Dec 18, 2019 •

edited

Loading

SergejDK commented Dec 18, 2019

TimLariviere commented Dec 18, 2019

TimLariviere commented Dec 18, 2019

TimLariviere left a comment •

edited

Loading

SergejDK commented Dec 18, 2019 •

edited

Loading

TimLariviere commented Dec 18, 2019

SergejDK commented Dec 18, 2019

TimLariviere commented Dec 19, 2019 •

edited

Loading

SergejDK commented Dec 19, 2019 •

edited

Loading

SergejDK commented Dec 20, 2019

SergejDK commented Jan 2, 2020

TimLariviere left a comment •

edited

Loading

TimLariviere Feb 2, 2020 •

edited

Loading

TimLariviere Feb 2, 2020

TimLariviere Feb 2, 2020

TimLariviere commented Feb 2, 2020 •

edited

Loading

TimLariviere left a comment

magnushammar commented Feb 11, 2020

XF Upgrade 4.4 #644

XF Upgrade 4.4 #644

Conversation

SergejDK commented Dec 18, 2019 • edited Loading

SergejDK commented Dec 18, 2019

TimLariviere commented Dec 18, 2019

TimLariviere commented Dec 18, 2019

TimLariviere left a comment • edited Loading

Choose a reason for hiding this comment

SergejDK commented Dec 18, 2019 • edited Loading

TimLariviere commented Dec 18, 2019

SergejDK commented Dec 18, 2019

TimLariviere commented Dec 19, 2019 • edited Loading

SergejDK commented Dec 19, 2019 • edited Loading

SergejDK commented Dec 20, 2019

SergejDK commented Jan 2, 2020

TimLariviere left a comment • edited Loading

Choose a reason for hiding this comment

TimLariviere Feb 2, 2020 • edited Loading

Choose a reason for hiding this comment

TimLariviere Feb 2, 2020

Choose a reason for hiding this comment

TimLariviere Feb 2, 2020

Choose a reason for hiding this comment

TimLariviere commented Feb 2, 2020 • edited Loading

TimLariviere left a comment

Choose a reason for hiding this comment

magnushammar commented Feb 11, 2020

SergejDK commented Dec 18, 2019 •

edited

Loading

TimLariviere left a comment •

edited

Loading

SergejDK commented Dec 18, 2019 •

edited

Loading

TimLariviere commented Dec 19, 2019 •

edited

Loading

SergejDK commented Dec 19, 2019 •

edited

Loading

TimLariviere left a comment •

edited

Loading

TimLariviere Feb 2, 2020 •

edited

Loading

TimLariviere commented Feb 2, 2020 •

edited

Loading