Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade samples to Android Pie (9.0) #446

Merged

Conversation

TimLariviere
Copy link
Member

Partial cover of #442

Update the samples to compile for Android Pie (9.0) instead of Oreo (8.1).
Also samples now start support at Android Lollipop 5.0 (API Level 21) instead of Android KitKat 4.4

This is required to be able to use Shell and Visual.

@SergejDK
Copy link
Collaborator

SergejDK commented Jun 10, 2019

Looks good so far but currently the Calculator App does not work anymore. Can't make it work on my device (Motorola G6 Plus). Don't know if it is only me.

EDIT:
Works now. Configurationmanager needed to provide Calculator.Droid (wasn't set as porvided like the other projects); rebuild and restart after this worked.

So all good!

@SergejDK
Copy link
Collaborator

Merging it now.

@SergejDK SergejDK merged commit b176c22 into fabulous-dev:master Jun 11, 2019
@TimLariviere TimLariviere deleted the upgrade-samples-android-pie branch June 11, 2019 14:48
@TimLariviere
Copy link
Member Author

Works now. Configurationmanager needed to provide Calculator.Droid (wasn't set as porvided like the other projects); rebuild and restart after this worked.

@SergejDK I'm not sure to understand.
What do you mean by "ConfigurationManager needed to provide Calculator.Droid"?

@SergejDK
Copy link
Collaborator

SergejDK commented Jun 11, 2019

@TimLariviere have it on german so i hope the follwoing screenshot shows what i mean:

grafik

@SergejDK
Copy link
Collaborator

the right column i think translated should be "provided" or "supplied"...
If you check this it works.

@TimLariviere
Copy link
Member Author

Ah ok. In English, the columns are "Build" and "Deploy".
So makes sense, it weren't working.

Visual Studio prevented the sample to be deployed on your device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants