Update to XF 3.5 #350

SergejDK · 2019-03-03T23:22:24Z

The following list shows which are missing right now. Will work on this the next days.

The questionmark behind few classes there I do not know if they are needed.
Interfaces, enums, abstract classes and static classes are not included.
I think that the Attributes and EventArgs do not need to be included, too ???

@TimLariviere could you maybe provide me with some hints for the classes below and the question above? I appreciate your help!

fix #329

Differences:
https://www.fuget.org/packages/Xamarin.Forms/3.5.0.129452/lib/netstandard2.0/diff/3.4.0.1009999/

TimLariviere · 2019-03-05T10:32:44Z

I think that the Attributes and EventArgs do not need to be included, too ???

Yes, if we can reuse the existing classes, we do.
EventArgs are only a "bag" of data, so no need to wrap it in Fabulous.
Attributes as well, it's more related to making custom controls which is not something that concern Fabulous.

TimLariviere · 2019-03-05T10:35:51Z

I didn't had time to check XF 3.5 in details.
But I can say that we are only interested in actual controls, there's no need to wrap things like MenuItemCollection, NavigableElement, etc.

In the case of XXXCollection, Fabulous will expose a ViewElement list instead.

SergejDK · 2019-03-05T10:46:52Z

Great! Thanks for your feedback :)!

SergejDK · 2019-03-06T08:23:22Z

I think i got everything...

TimLariviere · 2019-03-06T08:48:12Z

@SergejDK Do you know why CollectionView/CarouselView/Shell are in XF 3.5?
Everything I read about them is about Xamarin.Forms 4.0 Preview

SergejDK · 2019-03-06T08:53:11Z

They are already in 3.5 but only allowed to use when setting: global::Xamarin.Forms.Forms.SetFlags("Shell_Experimental");

https://docs.microsoft.com/de-de/xamarin/xamarin-forms/app-fundamentals/shell?tabs=android

The question why it is in 3.5 I think because of earlier feedback from the devs.

BONUS: Keep in mind that 3.5.0 also contains previews of other new features that the Xamarin team is currently developing,. We look forward to receiving your feedback on Shell, Visual, CollectionView, and CarouselView. As you explore these features, please take a moment to share with us your thoughts here.

https://blog.xamarin.com/5-things-youll-love-xamarin-forms-3-5/

SergejDK · 2019-03-06T10:10:13Z

@TimLariviere the fail on travis - is it the error where it only needs to rerun?

TimLariviere · 2019-03-06T10:17:29Z

Seems like it.
For some reasons, it failed to download Xamarin.Forms.
Will retrigger the CI

SergejDK · 2019-03-06T12:06:03Z

@TimLariviere
Any other ideas? Most times the error goes away when rerun but right now not...
Maybe I missed a dependency?

TimLariviere · 2019-03-06T13:53:30Z

Apparently they changed their targeting framework with Xamarin.Forms 3.5.
In XF <= 3.4, Xamarin.Android was using the folder MonoAndroid10
But now, it's using either MonoAndroid81 or MonoAndroid90

So the links in both the samples app and the templates are no longer valid.

For example:

<Reference Include="Xamarin.Forms.Core">
    <HintPath>..\packages/Xamarin.Forms.XamarinFormsSdk/lib/MonoAndroid10/Xamarin.Forms.Core.dll</HintPath>
</Reference>

will become

<Reference Include="Xamarin.Forms.Core">
    <HintPath>..\packages/Xamarin.Forms.XamarinFormsSdk/lib/MonoAndroid90/Xamarin.Forms.Core.dll</HintPath>
</Reference>

SergejDK · 2019-03-06T17:00:14Z

Thanks for looking into it! Could not do it when I was at work...
Will change it.

tools/Generator/Xamarin.Forms.Core.json

TimLariviere · 2019-03-11T11:54:58Z

Could you add an example of how to use the new controls in the AllControls samples?

SergejDK · 2019-03-11T12:12:58Z

Would it not be better to have a project for shell and not include it in AllControls?
I think the AllControls will be hard to read if we add everything in it.

And with the Shell it mabye easier to work on: #242

TimLariviere · 2019-03-11T12:22:06Z

I think we should still add the new controls to AllControls, it's more a smoke test than a sample anymore. That way, we can check the new controls are working and we don't break them later.

Though indeed, Shell would be easier to use in a new project and provides a good structure for new samples.

SergejDK · 2019-03-11T12:41:59Z

I will add simple parts in the allcontrols.

TimLariviere · 2019-03-11T12:42:31Z

Thanks!

SergejDK · 2019-03-11T12:52:17Z

Existing iOS and Android applications can adopt Shell and benefit immediately from navigation, performance, and extensibility improvements.

Because Shell seems to be only available on Android and iOS I have to ask for the platform. This is just a note that you won't be suprised about the addition to ask for android and ios.

SergejDK · 2019-03-19T20:34:48Z

@TimLariviere
I think for shell we do truly need a project because we need to use sth like.

FormsAppCompatActivity.TabLayoutResource <- TicTacToe.Droid.Resources.Layout.Tabbar
FormsAppCompatActivity.ToolbarResource <- TicTacToe.Droid.Resources.Layout.Toolbar

Else it should give an error.

If I am correct then there is only CarouselView/CollectionView to make examples in allcontrols?

Last thing: I am still trying to figure out what is wrong with the items updateCode. If you have any hint I would appreciate it!!

TimLariviere · 2019-03-25T08:35:45Z

And if I am right I made more work than I had to do... I think I can delete the BaseShellItem?

Yes, I think you're right.
Some "abstract" controls don't need to be exposed in Fabulous. We only want to expose those we can use directly.

If I am correct then there is only CarouselView/CollectionView to make examples in allcontrols?

Yes, there seems to be only 3 new controls: Shell, CarouselView and CollectionView.
The others are more generic controls that serve as a base for those 3.

SergejDK · 2019-03-26T23:17:40Z

Added examples for carousel and collectionview but I think there is something wrong.
If I try to add sth. like View.Label in the itemssource property it won't render.
So here I think I need to overwrite it somehow in the members or is there another way?

TimLariviere · 2019-03-28T07:41:15Z

@SergejDK The ItemsSource property on ItemsView (inherited by Carousel and CollectionView) is not enough for Fabulous. ViewElement won't render itself by default.

You need to do something like the ListView does:

Create a data holder with PropertyChanged support
https://github.com/fsprojects/Fabulous/blob/1c435ccc61d58efb6820706bce56c24e68b00a28/src/Fabulous.Core/ViewConverters.fs#L27-L41
Create a custom made control which will be responsible of rendering the related ViewElement
https://github.com/fsprojects/Fabulous/blob/1c435ccc61d58efb6820706bce56c24e68b00a28/src/Fabulous.Core/ViewConverters.fs#L70-L112
Create a custom CarouselView/CollectionView initialized with a DataTemplate of the new control (which is responsible for rendering the ViewElement)
https://github.com/fsprojects/Fabulous/blob/1c435ccc61d58efb6820706bce56c24e68b00a28/src/Fabulous.Core/ViewConverters.fs#L114-L116
And finally, tell the Generator you want to instantiate your custom control whenever you call View.Carousel/View.CollectionView
https://github.com/fsprojects/Fabulous/blob/1c435ccc61d58efb6820706bce56c24e68b00a28/tools/Generator/Xamarin.Forms.Core.json#L1804-L1814

That way, when you add a View.Label in the ItemsSource property, Fabulous will wrap it in a ItemsViewElementData (1st step) and add it to the actual ItemsSource property.
Then when displaying, the Carousel/CollectionView will call ItemsViewItem to handle the rendering of the ItemsViewElementData.

SergejDK · 2019-03-29T08:19:27Z

@TimLariviere great explanation! Thanks!

As far as I see I can nearly copy everything except changing some names and inherited classes. Am I right?
-- Tried it that way but I get an InvalidCastException. Currently I am searching where this happens. It kinda does not show which line or anything else.

TimLariviere · 2019-03-29T10:05:15Z

As far as I see I can nearly copy everything except changing some names and inherited classes. Am I right?

Yes, it should mostly work as-is.
Just watch out for inherit ViewCell(), Carousel/CollectionView might not use this class for templating.

SergejDK · 2019-04-02T19:54:05Z

It seems like everythign can be used.
https://blog.xamarin.com/xamarin-forms-4-0-feature-preview-an-entirely-new-point-of-collectionview/

So maybe inherit from view directly? The difference to ListView is that listview uses ItemsView<Cell> but Collection/Carousel uses ItemsView class.

TimLariviere · 2019-04-03T08:16:54Z

So maybe inherit from view directly?

@SergejDK You can inherit from ContentView and append the ViewElement's control to the Content property.

SergejDK · 2019-04-03T21:39:23Z

Seems to work but it does not display anything. It gets created correctly though...

SergejDK · 2019-04-08T21:46:31Z

The Labels seems to be created but not shown in the ui:

Is there still sth. wrong within ItemViewElementCell?
No Exception - nothing to check...
@TimLariviere Any hint on this?

SergejDK · 2019-05-12T20:30:10Z

Got time again.
Very interesting...
CollectionView on iOS is working on Android not.
CarouselView does not work. Will take a deeper look

2019-05-12 22:33:33.491404+0200 iOS[15591:395681] Unable to update view:: System.InvalidCastException: Specified cast is not valid. is the problem of carouselview.

SergejDK · 2019-05-13T10:51:05Z

@TimLariviere
if I get it right the CarouselView for iOS is not implemented in XF3.5: xamarin/Xamarin.Forms#5488
So this won't work no matter how much effort I put into it.

will test for android part.
Android carousel is working.
Only Collectionview is open now for android

SergejDK · 2019-05-14T21:41:20Z

@TimLariviere
it can be that with further updates maybe to 3.6/4.0 the issue won't be there anymore.

So maybe it is okay to merge here even though the examples for the 3 parts are currently not working.

For those example we can open each issue and work on the updates so we can catch up there and afterwards test the examples again.

What do you think?

TimLariviere · 2019-05-15T18:16:57Z

@SergejDK Alright.
As those controls are preview only in XF 3.5, I think we can merge this PR for now and fix them once they're fully available (likely with XF 4.0).

I'll add a note for these controls in the docs saying that while we provide an initial support, there may be some issues with them.

SergejDK · 2019-05-15T20:05:46Z

@TimLariviere
Great Job! Thanks for keeping up with the work!

SergejDK · 2019-05-15T20:48:44Z

@TimLariviere
I think it is the normal problem where we need to restart the build on travis?

TimLariviere · 2019-05-16T08:48:28Z

@SergejDK Thank you for your work in this long running PR. :)
I'm merging this now.

This evening I'll be releasing this in a new version on NuGet.

SergejDK · 2019-05-16T08:57:17Z

@TimLariviere
always happy to help :)
I think everyone is waiting for the release

what do you think about making the step to 3.6 ? Maybe I can make it before evening and you could release it with 3.6?

aspnetde · 2019-05-16T08:58:45Z

what do you think about making the step to 3.6 ? Maybe I can make it before evening and you could release it with 3.6?

That would be awesome!

SergejDK and others added 5 commits March 3, 2019 23:58

first part of update

f22af9e

selectableItemsView + shellgroupitem

5122377

itemsview, shellnavigationstate

2e4f35f

shell

570d8d0

shellcontent, shellitem, shellsection first input

4aae2dc

Sergej Dick added 2 commits March 6, 2019 08:30

added events for shell and shellsection

8124c5a

carouselview, collectionview ...

f4cab27

SergejDK marked this pull request as ready for review March 6, 2019 08:21

Merge remote-tracking branch 'upstream/master' into xf35update

1c3ee43

TimLariviere closed this Mar 6, 2019

TimLariviere reopened this Mar 6, 2019

changed folderpath

149f4fe

TimLariviere reviewed Mar 11, 2019

View reviewed changes

tools/Generator/Xamarin.Forms.Core.json Show resolved Hide resolved

added example carousel and collectionview

f18a856

added xamarin flags for collectionview carousel and shell

82e50c8

collection/carouselview viewconverter functions

090812f

SergejDK added 2 commits April 8, 2019 23:22

Merge remote-tracking branch 'upstream/master' into xf35update

0e593de

merge

56ecd6c

TimLariviere added 2 commits May 15, 2019 19:16

Merge branch 'master' into xf35update

6d4f4d6

Merge branch 'master' into xf35update

bcdeea0

docs

a52b87e

TimLariviere approved these changes May 15, 2019

View reviewed changes

TimLariviere merged commit 64595d4 into fabulous-dev:master May 16, 2019

TimLariviere mentioned this pull request May 16, 2019

0.34.0 #410

Merged

Update to XF 3.5 #350

Update to XF 3.5 #350

Conversation

SergejDK commented Mar 3, 2019 • edited Loading

TimLariviere commented Mar 5, 2019

TimLariviere commented Mar 5, 2019 • edited Loading

SergejDK commented Mar 5, 2019

SergejDK commented Mar 6, 2019

TimLariviere commented Mar 6, 2019

SergejDK commented Mar 6, 2019

SergejDK commented Mar 6, 2019

TimLariviere commented Mar 6, 2019

SergejDK commented Mar 6, 2019

TimLariviere commented Mar 6, 2019

SergejDK commented Mar 6, 2019

TimLariviere commented Mar 11, 2019

SergejDK commented Mar 11, 2019

TimLariviere commented Mar 11, 2019

SergejDK commented Mar 11, 2019

TimLariviere commented Mar 11, 2019

SergejDK commented Mar 11, 2019

SergejDK commented Mar 19, 2019 • edited Loading

TimLariviere commented Mar 25, 2019

SergejDK commented Mar 26, 2019

TimLariviere commented Mar 28, 2019

SergejDK commented Mar 29, 2019 • edited Loading

TimLariviere commented Mar 29, 2019

SergejDK commented Apr 2, 2019

TimLariviere commented Apr 3, 2019

SergejDK commented Apr 3, 2019

SergejDK commented Apr 8, 2019 • edited Loading

SergejDK commented May 12, 2019 • edited Loading

SergejDK commented May 13, 2019 • edited Loading

SergejDK commented May 14, 2019

TimLariviere commented May 15, 2019

SergejDK commented May 15, 2019

SergejDK commented May 15, 2019

TimLariviere commented May 16, 2019

SergejDK commented May 16, 2019

aspnetde commented May 16, 2019

SergejDK commented Mar 3, 2019 •

edited

Loading

TimLariviere commented Mar 5, 2019 •

edited

Loading

SergejDK commented Mar 19, 2019 •

edited

Loading

SergejDK commented Mar 29, 2019 •

edited

Loading

SergejDK commented Apr 8, 2019 •

edited

Loading

SergejDK commented May 12, 2019 •

edited

Loading

SergejDK commented May 13, 2019 •

edited

Loading