Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

take out fscd, use paket to acquire it #303

Merged
merged 3 commits into from
Feb 1, 2019
Merged

Conversation

dsyme
Copy link
Collaborator

@dsyme dsyme commented Jan 30, 2019

This takes out the core code-format and interpreter code and tests, including it via source inclusion for the moment.

@dsyme
Copy link
Collaborator Author

dsyme commented Jan 30, 2019

See #302

@dsyme
Copy link
Collaborator Author

dsyme commented Jan 31, 2019

@TimLariviere Just to mention that I still think Fabulous should include its own CLI tool, even if only a very thin packaging wrapper over the generic FSharp.Compiler.PortaCode functionality.

This is because the on-device interpreter in Fabulous.LiveUpdate needs to match the PortaCode data format being sent by the live update tool. It's much easier for these to be kept in sync if the Fabulous CLI version numbers match the Fabulous.LiveUpdate version numbers (and the Fabulous docs explain that this needs to be the case)

@TimLariviere
Copy link
Member

TimLariviere commented Jan 31, 2019

@dsyme Ok, I see.
Do we check at runtime if the version matches between the CLI and LiveUpdate?

I think we also need to update the docs to reflect the need to update the CLI when migrating to a new release.

@dsyme
Copy link
Collaborator Author

dsyme commented Jan 31, 2019

Do we check at runtime if the version matches between the CLI and LiveUpdate?

No we don't, we should. I suppose that has to be in the info sent to the webhook

@dsyme
Copy link
Collaborator Author

dsyme commented Jan 31, 2019

@TimLariviere This is ready

@dsyme
Copy link
Collaborator Author

dsyme commented Jan 31, 2019

@TimLariviere I've already made some interpreter improvements in FSharp.PortaCode which we should bring in, but we can do that bit by bit

@dsyme
Copy link
Collaborator Author

dsyme commented Jan 31, 2019

Improvements to the interpreter are here: fsprojects/FSharp.Compiler.PortaCode#2

@TimLariviere TimLariviere merged commit 892c59b into fabulous-dev:master Feb 1, 2019
This was referenced Feb 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants