Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added testing for macOS & GTK templates #294

Merged

Conversation

TimLariviere
Copy link
Member

As discussed in #287, we were not testing the macOS and GTK templates in the build process.

@TimLariviere TimLariviere changed the title [WIP] Added testing for macOS & GTK templates Added testing for macOS & GTK templates Jan 24, 2019
@TimLariviere
Copy link
Member Author

TimLariviere commented Jan 24, 2019

Travis CI seems happy with this.

Oddly enough, on my machine (macOS), when building the GTK project it deletes the dll of the shared project.
Thus the macOS project fails due to not being able to find the dll.

Does someone have a similar problem? @mallibone

@dsyme
Copy link
Collaborator

dsyme commented Jan 24, 2019

This is fantastic. I checked the travis log and it is indeed building macOS

�[39;49m�[39;49m�[37m  /Library/Frameworks/Mono.framework/Versions/5.18.0/lib/mono/fsharp/fsc.exe -o:obj/Debug/testapp269.macOS.exe

@mallibone
Copy link

@TimLariviere interesting I will give it a spin later today, I did not have any issues back before we were "fighting" with Travis 🙃

I am looking forward to running this PR on the Azure DevOps PR.

@mallibone
Copy link

@TimLariviere I pulled this branch and ran ./build.sh Test without any issues locally on my Mac running Mojave 10.14.2, latest XCode and Visual Studio (stable). But it does seem odd that it fails on your end.

@TimLariviere
Copy link
Member Author

TimLariviere commented Jan 24, 2019

Well I'm glad it's only on my end.
Maybe VS for Mac 2019 is doing something funny.

@TimLariviere TimLariviere merged commit c625f2c into fabulous-dev:master Jan 24, 2019
@TimLariviere TimLariviere deleted the 55bis-testing-templates branch January 24, 2019 17:39
@TimLariviere TimLariviere mentioned this pull request Feb 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants