added a documentation for webrequest

[SergejDK]

Documentation for making a webrequest is added in the documentation.

Is there a need for the example application?

fix #66

[TimLariviere]

Thanks! It looks good.
Indentation could use a little fixing (in the code samples), but apart from that, it's great.

Is there a need for the example application?

Yes, please.

[SergejDK]

Will take a look at the identation this evening.
Sample will be added in the samples folder, too.

[TimLariviere]

@SergejDK You can add this sample in the AllControls sample directly I think.

[SergejDK]

Ok, should not be a Problem.

[SergejDK]

MacOs, iOS and GTK need to be tested.
Somehow i can't add a nuget package there...

[SergejDK]

On Mac, iOs and GTK I get:

Could not load type of field 'Fabulous.DynamicViews.ViewElement:update' (0) due to: Could not resolve type with token 01000021 from typeref (expected class 'Microsoft.FSharp.Core.FSharpValueOption1' in assembly 'FSharp.Core, Version=4.5.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a') assembly:FSharp.Core, Version=4.5.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a type:Microsoft.FSharp.Core.FSharpValueOption1 member:(null)

@TimLariviere do you know why?

[SergejDK]

Did not change anything, now it works on iOS, macOS and GTK.
But macOS has still a bug. When clicked on "MainPage" it gets a nullreference exception.

[TimLariviere]

@SergejDK Yes, I saw this one when I tested the macOS node of AllControls.
If you can gather more information and open an issue, it would be great.
Thank you.

I'll take a look later to see if I can find why you were having an error with FSharpValueOption.

[SergejDK]

The issue with the nullreference is in XF itself.
Will open an issue here just to show the others that is in progress.
xamarin/Xamarin.Forms#4156

[SergejDK]

The Travis build fails because it can not download fsharp data into the Android project. Any ideas ?

[TimLariviere]

Yes, the samples don't use NuGet/packages.config.
Instead, we add the dependency in paket (https://github.com/fsprojects/Fabulous/blob/master/paket.dependencies) and then we make a manual reference to the dll in the fsproj.

This is kinda counter-intuitive.
But someday, I hope we can make that better. See #181 and #222.

For example: FSharp.Core in Android
https://github.com/fsprojects/Fabulous/blob/0f76787cba92635a6b7cb2c90242c5975b6b9bbc/paket.dependencies#L17-L20

https://github.com/fsprojects/Fabulous/blob/0f76787cba92635a6b7cb2c90242c5975b6b9bbc/samples/AllControls/Droid/AllControls.Droid.fsproj#L167-L169

So, to add FSharp.Data for Android, you can add a line in the group androidapp in the paket.dependencies file.
Make sure to do a paket.exe install to download the dependency on your machine.
Then change the path to the dll in the fsproj.

Also remove the unused packages.config.

[SergejDK]

Thanks!
Forgot about Paket ...
Will change asap

[TimLariviere]

Paket doesn't add the version number in the path

Suggested change

	<HintPath>../../../packages/androidapp/FSharp.Data.3.0.0/lib/netstandard2.0/FSharp.Data.dll</HintPath>
	<HintPath>../../../packages/androidapp/FSharp.Data/lib/netstandard2.0/FSharp.Data.dll</HintPath>

[TimLariviere]

Can you remove this line and the associated file (if still there)? Thanks

[TimLariviere]

Versioning is centralized in the Packages.targets file at the root of the repository.
In this file, you only need to include the package (without version)
Then in the Packages.targets, you can add the version, just like the other packages.

Suggested change

	<PackageReference Include="FSharp.Data" Version="3.0.0" />
	<PackageReference Include="FSharp.Data" />

[SergejDK]

learned a lot ! Thank you 👍

[TimLariviere]

@SergejDK The sample works great!

[TimLariviere]

Thank you. I'm merging it now.

[dsyme]

This is a fantastic addition to the docs