fix interpreter bugs and make it pass tests #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Yes, they're under CI. But only Travis CI (macOS) actually runs them (FAKE target "Test"). Do you know which ones were failing? |
Ah ok, it might be that my first fix caused others to fail, and so on - I didn't test them clean. Now all are passing and the new tests are well, so all are good |
|
@dsyme Is this PR ready to be merged? |
|
@TimLariviere Yes it is, thanks |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix most bugs in #281
@TimLariviere It seems like a few of the Cli.Tests weren't passing, and so I patched things up - odd how many were failing. Are they under CI? I checked
build.fsxand it looks like they are