Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GTK as target template #268

Merged
merged 7 commits into from
Jan 4, 2019
Merged

Add GTK as target template #268

merged 7 commits into from
Jan 4, 2019

Conversation

mallibone
Copy link

As described in issue this adds GTK as template to Fabulous.

  • Add empty Template for GTK
  • Add GTK to the dotnet template

@mallibone mallibone force-pushed the master branch 4 times, most recently from f16db6e to 53a380b Compare January 2, 2019 18:25
@TimLariviere
Copy link
Member

I've updated NuGet.exe and it fixed the Travis CI build fail.
Could you rebase your PR on the last commit on master please?

@mallibone
* Add empty Template for GTK
6b3ecbc 
* Add GTK to the dotnet template
@mallibone
Copy link
Author

Cool thanks for fixing the build 🙂 Updating NuGet.exe why didn't I think of that myself 🙈

TimLariviere
TimLariviere requested changes Jan 3, 2019
View reviewed changes
Copy link
Member

@TimLariviere TimLariviere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes are needed but this looks good!
I'm preparing a Linux machine to test it.

Also I think you're missing a guid in the template.json file
Line 51-52, you need to add the Gtk project guid
"E9A5BEFA-0E53-40B7-B2F8-DDB8369E644D"

templates/content/blank/NewApp.Gtk/NewApp.Gtk.fsproj Show resolved Hide resolved
templates/content/blank/NewApp.Gtk/packages.config Outdated Show resolved Hide resolved
templates/content/blank/.template.config/template.json Outdated Show resolved Hide resolved
templates/content/blank/.template.config/template.json Outdated Show resolved Hide resolved
templates/content/blank/.template.config/template.json Outdated Show resolved Hide resolved
templates/content/blank/NewApp.Gtk/Main.fs Outdated Show resolved Hide resolved
templates/content/blank/NewApp.sln Outdated Show resolved Hide resolved
@TimLariviere
Copy link
Member

TimLariviere commented Jan 3, 2019 •
edited
Loading

I have tested it on a freshly installed Ubuntu Mate and it worked immediately :)
👍

@mallibone
Copy link
Author

Code fixes are now implemented. Also found an issue with the template under Windows and fixed it.

@TimLariviere TimLariviere merged commit 9741712 into fabulous-dev:master Jan 4, 2019
@TimLariviere TimLariviere mentioned this pull request Jan 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimLariviere TimLariviere TimLariviere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mallibone @TimLariviere