-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made fscd a dotnet CLI tool "fabulous-cli" + Unit tests ran on FAKE build #247
Made fscd a dotnet CLI tool "fabulous-cli" + Unit tests ran on FAKE build #247
Conversation
Tests are running. Great. I'll take a look at converting |
And now it's a dotnet cli tool, which allows to do that on all platforms
Hopefully, this will close #120 and #141 as well.
Visual Studio 2019 Preview 1 can't load the Fabulous repository. |
@nosami @jimbobbennett @dsyme Steps to install your own fabulous-cli
Thanks |
I just gave this a try. Changes to any file in the source folder (made with VSMac) were detected immediately and it was very stable. 💯 |
I tried to do this a few months ago but back then there were serialization differences between Mono running on the device and dotnet running in the watcher that meant this wasn't possible. On dotnet core, the serialized types referred to System.Private.CoreLib which isn't available on Mono. I'm not sure if this issue has been resolved - I need to check if there are issues in the emulator when refreshing. |
That's really good to hear. :) |
@TimLariviere @nosami Sorry I've been a bit out of the loop due to a trip to Redmond. Hoping to get back into Fabulous in the next few days before Xmas vacation |
I looked through.... this work is absolutely .... yes... you know what I'm about to say... Absolutely Fabulous! |
Just tried it on one of my projects and get errors, but also got errors with the old watcher. Seems it doesn’t like a timer subscription... will raise an issue for it. |
70c5c46
to
0b4a880
Compare
Ok, this sounds good. Did another successful set of manual tests with fabulous-cli. :) There's a lot of limitations with LiveUpdate I think we should track as issues, to see if we can fix them. |
Making this PR mostly to test CI.
Fixing
fscd.Tests
to run on all platforms and run it as part of the build process.2 tests have been disabled because of a known limitation of FSharp.Compiler.Service.
Also had to make
fscd.Tests
a .NET Core library to run outside of Visual Studio (FAKE 5 can't run MSTest v2 on MacOS, even though VSfM can run it)So I also made
fscd
a .NET Core app which change the way we run itmono fscd.exe --watch
=>dotnet fscd.dll --watch