Adding StyleClass to VisualElement

[davidglassborow]

see #205

[TimLariviere]

Well done!
Do you know if there's some limitation with changing/removing css?

I tried some cases with the AllControls app, but it doesn't seem to update correctly. (after clicking a new button to switch styles)

• "cssCallout" changed to "cssRed" (.cssRed { color: Red; })
• "cssCallout" changed to ""

They don't update visually, even though the control itself is properly updated

[davidglassborow]

Maybe an XF bug ? Looking at xamarin/Xamarin.Forms#3824, maybe related. Same issue seems to exist with StyleId.

CSS is pretty new in XF, so maybe we can assume a XF limitation for the moment ?

Doesn't affect my use case for the moment so I'm keen to get this merged and nuget updated if your happy ?

[dsyme]

The styleClass parameter should be added for each of the three extensions, e.g. here https://github.com/fsprojects/Fabulous/blob/master/extensions/Maps/Xamarin.Forms.Maps.fs#L32

It's annoying to have to do this but not too hard.

[dsyme]

Looks like the Unix build is failing, I'm not totally sure why

[TimLariviere]

Yes, noticed it as well.
It fails for a different reason each time (aapt missing, missing NuGet package, etc.), but most of the times it works.

[davidglassborow]

Thanks @dsyme I've added styleClass to the 3 extensions as well. Fingers crossed CI is happy :-)

[davidglassborow]

CI / Paket failing for some reason. That package is available on nuget so no idea why travis is failing.

Paket failed with
-> Could not download OpenTK.GLControl 3.0.1.
-> Couldn't get package details for package OpenTK.GLControl 3.0.1 on https://api.nuget.org/v3/index.json.

[TimLariviere]

NuGet is currently having troubles: https://status.nuget.org/

[TimLariviere]

The issue I mentioned is tracked here: xamarin/Xamarin.Forms#2678