Added support for PodSecurityPolicy #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok to test |
oscerd
approved these changes
Jan 19, 2018
|
OK to test |
hrishin
reviewed
Jan 22, 2018
| if (kind.endsWith("ses")) { | ||
| kind = kind.substring(0, kind.length() - 2); | ||
| } else if (kind.endsWith("s")) { | ||
| } |
There was a problem hiding this comment.
@piyush1594 this is really good catch! 👍
rohanKanojia
approved these changes
Jan 22, 2018
|
retest this please |
1 similar comment
|
retest this please |
|
Please rebase this PR to align the dependency to the latest kube-model |
|
Yes, @oscerd just realised and did that |
|
[merge] |
rohanKanojia
reviewed
Feb 5, 2018
|
|
||
| @After | ||
| public void cleanup() { | ||
| client.podSecurityPolicies().delete(); |
There was a problem hiding this comment.
I missed this in the initial part of the review. It's not a good idea to delete all the PodSecurityPolicy objects since they are not a namespace specific resource. Instead, you should simply delete the resource you created during test.
There was a problem hiding this comment.
Yes @rohanKanojia, you seem correct will send a quick PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#969