Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(crd-generator): Add support for selectable fields #6540

Merged
merged 5 commits into from
Nov 20, 2024
Merged

feat(crd-generator): Add support for selectable fields #6540

merged 5 commits into from
Nov 20, 2024

Conversation

baloo42
Copy link
Contributor

@baloo42 baloo42 commented Nov 4, 2024 •
edited
Loading

Description

Fixes #6392

Add support for selectable fields in CRD-Generator (api-v2).

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@baloo42 baloo42 marked this pull request as ready for review November 5, 2024 19:45
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 5, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@manusa manusa added this to the 7.0.0 milestone Nov 20, 2024 — with automated-tasks
manusa
manusa approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit 4beec62 into fabric8io:main Nov 20, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@metacosm metacosm metacosm approved these changes

@andreaTP andreaTP Awaiting requested review from andreaTP andreaTP is a code owner

@oscerd oscerd Awaiting requested review from oscerd oscerd is a code owner

@rohanKanojia rohanKanojia Awaiting requested review from rohanKanojia rohanKanojia is a code owner

@shawkins shawkins Awaiting requested review from shawkins shawkins is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

CRDGenerator: Selectable fields
3 participants
@baloo42 @metacosm @manusa