Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (kubernetes-model-generator) : Handle deserialization of defaultMode field in custom deserializers for VolumeSource types #6148

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Jul 17, 2024

Description

Fix #6110

Jackson doesn't properly handle deserialization of octal integer value in YAML

Jenkins Kubernetes Plugin team also faced some issues for octal handling, here is the linked PR jenkinsci/kubernetes-plugin#1503

Add custom deserializers to handle correct octal deserialization for these types:

  • ConfigMapVolumeSource
  • SecretVolumeSource
  • DownwardAPIVolumeSource
  • ProjectedVolumeSource

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

…Mode` field in custom deserializers for VolumeSource types

Add custom deserializers to handle correct octal deserialization for
these types:
- ConfigMapVolumeSource
- SecretVolumeSource
- DownwardAPIVolumeSource
- ProjectedVolumeSource

Signed-off-by: Rohan Kumar <[email protected]>
@rohanKanojia rohanKanojia marked this pull request as ready for review July 18, 2024 05:05
@manusa manusa force-pushed the pr/issue6110 branch 2 times, most recently from d3d1a6a to 649493b Compare July 18, 2024 10:53
Copy link

sonarcloud bot commented Jul 18, 2024

@manusa manusa added this to the 7.0.0 milestone Jul 18, 2024 — with automated-tasks
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit 9293e0a into fabric8io:main Jul 18, 2024
21 checks passed
@rohanKanojia rohanKanojia deleted the pr/issue6110 branch July 18, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Octal defaultMode notation in yaml not properly converted to json
2 participants