Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kubernetes-client-api): Add support for v1.APIVersions in KubernetesClient #6089

Merged
merged 1 commit into from
Jul 12, 2024
Merged

feat(kubernetes-client-api): Add support for v1.APIVersions in KubernetesClient #6089

merged 1 commit into from
Jul 12, 2024

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Jun 27, 2024 •
edited
Loading

Description

Fix #6066

🚧 Requires #6088 to be merged first

Add DSL entrypoint getAPIVersions() in Client interface

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@rohanKanojia rohanKanojia force-pushed the pr/issue6066-client-dsl branch from 5b95e61 to 4037c14 Compare July 11, 2024 11:40
@rohanKanojia
feat (kubernetes-client-api) : Add support for v1.APIVersions in Ku…
9ba6549 
…bernetesClient

Add DSL entrypoint `getAPIVersions()` in Client interface

Signed-off-by: Rohan Kumar <[email protected]>
@rohanKanojia rohanKanojia force-pushed the pr/issue6066-client-dsl branch from 4037c14 to 9ba6549 Compare July 11, 2024 12:09
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@rohanKanojia rohanKanojia marked this pull request as ready for review July 11, 2024 13:35
@manusa manusa mentioned this pull request Jul 12, 2024
Closed
18 tasks
@manusa manusa added this to the 7.0.0 milestone Jul 12, 2024 — with automated-tasks
manusa
manusa approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit 093d8cd into fabric8io:main Jul 12, 2024
20 of 21 checks passed
@rohanKanojia rohanKanojia deleted the pr/issue6066-client-dsl branch July 12, 2024 08:24
@manusa manusa changed the title feat (kubernetes-client-api) : Add support for v1.APIVersions in KubernetesClient feat(kubernetes-client-api): Add support for v1.APIVersions in KubernetesClient Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@oscerd oscerd Awaiting requested review from oscerd oscerd is a code owner

@shawkins shawkins Awaiting requested review from shawkins shawkins is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

Add support for v1.APIVersions in KubernetesClient
2 participants
@rohanKanojia @manusa