Model getters have same annotations as fields (breaks native)

[manusa]

Description

Fix #6085 annotate getters with same Jackson annotations as fields.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change
• Chore (non-breaking change which doesn't affect codebase;
  test, version modification, documentation, etc.)

Checklist

• Code contributed by me aligns with current project license: Apache 2.0
• I Added CHANGELOG entry regarding this change
• I have implemented unit tests to cover my changes
• I have added/updated the javadocs and other documentation accordingly
• No new bugs, code smells, etc. in SonarCloud report
• I tested my code in Kubernetes
• I tested my code in OpenShift

[sonarcloud]

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

[manusa]

@shawkins @galderz

This is passing now.

The new approach is to add the JsonInclude and JsonUnwrapped annotations to getter methods too so that they share the same configuration.

If the issue in native mode was that there was divergent configuration for serialization properties and field configuration took precedence, then this should address it.

Let me know if I should merge this and include it in 6.13.1 or defer it to a possible 6.13.2 or alternative workaround.

[manusa]

I'm going to merge this since I don't think it causes any harm and might fix the downstream issue.

I'll try and release 6.13.1 tomorrow with this included, if you think this shouldn't go in or we should revert, please let me know today.

[jorsol]

Hi @manusa ,

There are still some methods that are not annotated like in io.fabric8.kubernetes.api.model.ObjectMeta (annotations, labels):

    @JsonProperty("annotations")
    @JsonInclude(JsonInclude.Include.NON_EMPTY)
    private Map<String, String> annotations = new LinkedHashMap<String, String>();

    @JsonProperty("annotations")
    public Map<String, String> getAnnotations() {
        return annotations;
    }

    @JsonProperty("annotations")
    public void setAnnotations(Map<String, String> annotations) {
        this.annotations = annotations;
    }

[manusa]

🤦 😮‍💨 too much logic scattered around.

I created another issue #6098 to fix this.