You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces #5699 as there have been no updates there in a while. Tweaks the previous pr to address the concerns mentioned in the review and to limit global locking to only methods that mutate the indexes / index functions.
Also some minor refactoring to make the CacheImpl logic a little more streamlined.
Type of change
Bug fix (non-breaking change which fixes an issue)
Feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change
Chore (non-breaking change which doesn't affect codebase;
test, version modification, documentation, etc.)
Checklist
Code contributed by me aligns with current project license: Apache 2.0
For some reason, there are tests failing. However, none of the modified production code seems to be related to these failures.
There was a subtle change that indexes used to allow null keys before, and now they don't with this code - I hadn't fully paid attention to a null check that was added in the previous pr. It seems like we should preserve that behavior, so I'll make an update.
@manusa should be good now. That test really wasn't of much use, so it's been removed. I did preserve the use of the concurrenthashmap for the index, but didn't see it made much difference of a synchronized map as we're never doing any iteration.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shawkins
requested review from
manusa,
oscerd,
rohanKanojia and
sunix
as code owners
Description
Fixes #5973
Replaces #5699 as there have been no updates there in a while. Tweaks the previous pr to address the concerns mentioned in the review and to limit global locking to only methods that mutate the indexes / index functions.
Also some minor refactoring to make the CacheImpl logic a little more streamlined.
Type of change
test, version modification, documentation, etc.)
Checklist