fix (kubernetes-client-api) : OpenIDConnectionUtils uses caCertFile and caCertData as a fallback option when idp-certificate-authority-data is not specified
#5818
+47
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanKanojia
force-pushed
the
pr/openid-cert-data-or-file
branch
2 times, most recently
from
a29197b to
88b9815
Compare
manusa
added a commit
that referenced
this pull request
Mar 25, 2024
rohanKanojia
force-pushed
the
pr/openid-cert-data-or-file
branch
2 times, most recently
from
631d870 to
17dff46
Compare
rohanKanojia
requested review from
manusa,
oscerd,
shawkins and
sunix
as code owners
oscerd
approved these changes
Apr 3, 2024
…nd caCertData as a fallback option when `idp-certificate-authority-data` is not specified Related to fabric8io#5817 Currently, we fall back to caCertData specified in Config when `idp-certificate-authority-data` is not specified. We should also consider reading cert data from caCertFile. Signed-off-by: Rohan Kumar <[email protected]>
rohanKanojia
force-pushed
the
pr/openid-cert-data-or-file
branch
from
17dff46 to
621885e
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #5817
Currently, we fall back to caCertData specified in Config when
idp-certificate-authority-datais not specified. We should also consider reading cert data from caCertFile. From discussion in redhat-developer/intellij-kubernetes#726 , user had cert data specified incaCertFileThe fix was tested by @adietish in build of IntelliJ Plugin and it seems to fix the issue for the user #5817 (comment)
I have tested the token refresh flow on EKS cluster (thanks to @adietish) , it seems to be working.
Type of change
test, version modification, documentation, etc.)
Checklist