fix #4460 removing the split packages #4464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manusa
approved these changes
Oct 4, 2022
| @@ -13,11 +13,14 @@ | |||
| * See the License for the specific language governing permissions and | |||
| * limitations under the License. | |||
| */ | |||
| package io.fabric8.kubernetes.client; | |||
| package io.fabric8.kubernetes.client.impl; | |||
There was a problem hiding this comment.
The test class name should probably be renamed
Feel free to use whatever naming you want - I don't have a strong preference. We'll probably want to re-assess the package names as well at some point. We could just have io.fabric8.kubernetes.client.(impl or internal) as the root package, rather than the two impls and two internals that will be there after this pr. |
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #4460
To support java modules (#4460) and cleaner OSGI support split packages need to be removed. Since we've now had 6.0 / 6.1 releases with the relevant client classes either explicitly or effectively deprecated we should be able to resolve this for splits that were introduced by the client/api refactorings.
kubernetes-client:
openshift-client:
Additionally a still deprecated DefaultKubernetesClient and DefaultOpenShiftClient adapters were added to the -api modules for continued compatibility when not using a builder. The actual implementations have been renamed XXXClientImpl.
I tested against a sample module project and this seemed to be sufficient to address the issue. There may be some more additional changes needed for OSGI - in particular the osgi.export and osgi.private should be reviewed for kubernetes-client and openshift-client @rohanKanojia is this something that you are familiar with?
Type of change
test, version modification, documentation, etc.)
Checklist