fix #3865: using just a single builder #3931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawkins
force-pushed
the
client
branch
2 times, most recently
from
462d82d to
930cada
Compare
manusa
reviewed
Mar 7, 2022
Comment on lines
258
to
265
| * <pre> | ||
| * { | ||
| * @code | ||
| * Config configFromBuilder = new ConfigBuilder(Config.empty()) | ||
| * // ... | ||
| * .build(); | ||
| * } | ||
| * </pre> |
There was a problem hiding this comment.
So my assumption is incorrect...
#3913 (comment)
We need to change the formatter configuration to prevent this.
There was a problem hiding this comment.
I've added a commit do this. It's org.eclipse.jdt.core.formatter.comment.format_source_comment = false that we need. However by itself that didn't seem to work for me. So I imported/exported a full config and that seemed to work.
There was a problem hiding this comment.
The correct option is org.eclipse.jdt.core.formatter.comment.format_source_code, which is working now: https://github.com/fabric8io/kubernetes-client/runs/5462546383?check_suite_focus=true
manusa
approved these changes
Mar 8, 2022
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the use of the OpenShiftClientBuilder and documents the use of KubernetesClientBuilder. Uses the same reflection strategy as KubernetesResourceUtil, but I didn't create a utility method for it just yet.
So the only odd man out is HttpClientUtils.createHttpClient since it only uses the thread context classloader - but I believe that is ok for now as at worst all someone would need to do is set an appropriate context class loader or set the httpclient.factory on the client builder. We should be able in subsequent releases move the logic from HttpClientUtils to the Kubernetes client factory to keep all in one place.
Depending upon the outcome of #3922 we can probably add a build(Class) shortcut for build().adapt(Class).
This also builds upon 0ca1325 to change OpenShiftConfig to just a decorator on a base config - no state can be lost if an openshiftconfig is inadvertently converted to base config.
Type of change
test, version modification, documentation, etc.)
Checklist