Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Examples usage of internal class SerializationUtils #3915

Merged

Conversation

manusa
Copy link
Member

@manusa manusa commented Mar 2, 2022

Description

Fix #3866

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@rohanKanojia rohanKanojia requested a review from shawkins March 2, 2022 16:46
@shawkins
Copy link
Contributor

shawkins commented Mar 2, 2022

@manusa can you now change the compile time dependency on -client to runtime?

@manusa
Copy link
Member Author

manusa commented Mar 3, 2022

@shawkins The AutoAdaptableKubernetesClient class seems to be no longer needed shall we create a PR/Issue to remove it?

#3865 (comment)

@manusa manusa force-pushed the doc/examples-dont-use-SerializationUtils branch from 352edef to a45cefa Compare March 3, 2022 11:17
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@shawkins
Copy link
Contributor

shawkins commented Mar 3, 2022

@shawkins The AutoAdaptableKubernetesClient class seems to be no longer needed shall we create a PR/Issue to remove it?

Yes, I don't see why someone would use that over just calling adapt on their own.

Copy link
Contributor

@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manusa manusa merged commit ab90b94 into fabric8io:master Mar 4, 2022
@manusa manusa deleted the doc/examples-dont-use-SerializationUtils branch March 4, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

examples still use -client internal SerializationUtils
4 participants