Add cert-manager extension support #2930

matthyx · 2021-03-18T14:15:54Z

Description

Type of change

Bug fix (non-breaking change which fixes an issue)
Feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change
Chore (non-breaking change which doesn't affect codebase;
test, version modification, documentation, etc.)

Checklist

Code contributed by me aligns with current project license: Apache 2.0
I Added CHANGELOG entry regarding this change
I have implemented unit tests to cover my changes
I have added/updated the javadocs and other documentation accordingly
No new bugs, code smells, etc. in SonarCloud report
I tested my code in Kubernetes
I tested my code in OpenShift

centos-ci · 2021-03-18T14:15:56Z

Can one of the admins verify this patch?

matthyx · 2021-03-18T14:16:39Z

relates to #2565

matthyx · 2021-03-18T14:18:51Z

@rohanKanojia here is where I am now:

go generator works
I have java files inside extensions/certmanager/model/target/generated-sources
unfortunately nothing ends up in any of the src folders

What am I doing wrong?

rohanKanojia · 2021-03-18T14:23:32Z

let me try to clone your branch and check later tonight

matthyx · 2021-03-18T14:27:25Z

let me try to clone your branch and check later tonight

sure, no rush... I am not the best Maven specialist, so it's probably down to my limited understanding of the whole mechanism.

matthyx · 2021-03-18T19:04:01Z

Wow, diff is epic and too much to check on the phone... I'll see later with the laptop while catching up on Netflix with my wife ;-)

matthyx · 2021-03-18T20:08:54Z

So basically you started from an older version of master, still 5.2?
The change that was needed for the java files to appear was to delete an ant task, or did you copy by hand?

matthyx

thanks for fixing my branch @rohanKanojia I just commented few places to understand the process
should I rebase on 5.3-SNAPSHOT?

matthyx · 2021-03-18T20:10:24Z

extensions/certmanager/generator/cmd/generate/generate.go

+		reflect.TypeOf(v1.Time{}):                  "java.lang.String",
+		reflect.TypeOf(metav1.ObjectReference{}):   "java.lang.String",
+		reflect.TypeOf(metav1.SecretKeySelector{}): "java.lang.String",
+                reflect.TypeOf(apiextensions.JSON{}): "com.fasterxml.jackson.databind.JsonNode",


not sure gofmt is happy with that...

matthyx · 2021-03-18T20:11:02Z

extensions/certmanager/generator/cmd/generate/generate.go

+	// no other types need to be defined as they are auto discovered
+	crdLists := map[reflect.Type]schemagen.CrdScope{
+		reflect.TypeOf(certmanager.CertificateList{}): schemagen.Namespaced,
+		reflect.TypeOf(certmanager.CertificateRequestList{}): schemagen.Namespaced,


how do you know which types to add? gut feeling?

I checked their provided CRDs: https://github.com/jetstack/cert-manager/tree/master/deploy/crds and added whatever I could

rohanKanojia · 2021-03-18T20:18:28Z

I tested building project on jdk11 before pushing to your branch. Quite strange it's failing on jdk8 due to some files getting generated twice. Let me add antrun tasks to delete duplicates.

rohanKanojia · 2021-03-18T20:23:52Z

So basically you started from an older version of master, still 5.2?
The change that was needed for the java files to appear was to delete an ant task, or did you copy by hand?

Umm, I think I did rebase your branch with master. I remember I replaced 5.2-SNAPSHOT with 5.3-SNAPSHOT. I had to copy ACMEChallengeSolverHTTP01Ingress to src/ since it has a field name Class which was causing build failures during sundrio generation

matthyx · 2021-03-18T20:26:07Z

So basically you started from an older version of master, still 5.2?
The change that was needed for the java files to appear was to delete an ant task, or did you copy by hand?

Umm, I think I did rebase your branch with master. I remember I replaced 5.2-SNAPSHOT with 5.3-SNAPSHOT. I had to copy ACMEChallengeSolverHTTP01Ingress to src/ since it has a field name Class which was causing build failures during sundrio generation

thanks for the explanation, everyday learning!

rohanKanojia · 2021-03-18T20:29:33Z

Bdw, cert-manager seems to have models for v1, v1alpha2, v1alpha3, v1beta1 . Shall we add those models too(right now we only have v1)? Do you know if cert-manager recently graduated it's api to v1 and whether it's going to stay there for long term?

matthyx · 2021-03-18T20:40:55Z

Bdw, cert-manager seems to have models for v1, v1alpha2, v1alpha3, v1beta1 . Shall we add those models too(right now we only have v1)? Do you know if cert-manager recently graduated it's api to v1 and whether it's going to stay there for long term?

I have no idea... but I never saw anything else than v1 in the examples. I'll keep looking and worse case I ask them.

matthyx · 2021-03-18T21:01:26Z

So, @munnerz replied on slack that v1 is supported since cert-manager 1.0.0 (released sept 2020) but older ones are still considered "valid".
If we want to help people on older installs (OpenShift 3.11 anyone?) we should support all of them...

Now that I see how you did it, I can work on that tomorrow if you want :-)

matthyx · 2021-03-19T15:17:14Z

@rohanKanojia I don't know about the CI errors here, but I think it only remains to add some examples and tests...

matthyx · 2021-03-25T11:00:14Z

@rohanKanojia I need your help here... impossible to understand how the generated sources are supposed to move from target/ to somewhere in src/
I think I have all good regarding the generators, but somehow missing some parts on the Maven side. Do you have some time to help me on that, please?

rohanKanojia · 2021-03-29T06:32:43Z

@matthyx : Sorry for the late reply. I don't think you need to worry about moving sources from target/ to src/ folder. In Kubernetes Model, most of our sources are being generated at compile time and they are not persisted into version control.

rohanKanojia · 2021-04-16T15:56:48Z

@matthyx : Hi, Are you still working on this? If you think it's ready could you please remove WIP from the PR title? I can request people for review then

matthyx · 2021-04-16T15:58:41Z

Hi Rohan, sorry it's not ready. I will work on this next week I promise :-)

rohanKanojia · 2021-04-16T15:59:14Z

No worries, no need to rush. Take your time. I just wanted to check this PR's status

vsevel · 2021-04-30T12:51:12Z

good job @matthyx

matthyx · 2021-05-25T13:13:02Z

@manusa do you know for which release this is planned, please?

manusa · 2021-05-25T13:26:46Z

@manusa do you know for which release this is planned, please?

Next minor release should be fine.

I tried to rebase your changes, but it required some additional work. I'm not sure if you can take care of this. If not, I'll try to do that next week.

matthyx · 2021-05-25T13:38:10Z

I tried to rebase your changes, but it required some additional work. I'm not sure if you can take care of this. If not, I'll try to do that next week.

Let me have a try...

irbekrm · 2021-06-07T08:57:38Z

Bdw, cert-manager seems to have models for v1, v1alpha2, v1alpha3, v1beta1 . Shall we add those models too(right now we only have v1)? Do you know if cert-manager recently graduated it's api to v1 and whether it's going to stay there for long term?

Hi folks 👋🏼 A drive-by comment that might or might not be relevant for you- the alpha and beta APIs are getting deprecated in the next release of cert-manager (v1.4) and will be removed in v1.6 cert-manager#4021](cert-manager/cert-manager#4021). (Also the v1 API is considered stable and long-term).

matthyx · 2021-06-07T09:41:41Z

awesome, maybe it will help me make my tests pass :-)

@manusa I am still failing to fix them, as for some reason my IntelliJ fails to compile the current project at master

manusa · 2021-06-07T09:51:57Z

@manusa I am still failing to fix them, as for some reason my IntelliJ fails to compile the current project at master

Could you provide more details about you failure?
Have you tried delegating the IntelliJ build to Maven?

matthyx · 2021-06-07T09:52:48Z

again those dreadful:

java: java.lang.NoClassDefFoundError: io/fabric8/kubernetes/client/extended/run/RunConfig
io.fabric8.kubernetes.client.extended.run.RunConfig

manusa · 2021-06-07T10:17:03Z

What about the Maven build delegation?

matthyx · 2021-06-07T10:20:02Z

What about the Maven build delegation?

Thanks, trying... (I swear I didn't need it in the past)

matthyx · 2021-06-07T14:59:29Z

@manusa could you check why the Karaf test failed? I swear I didn't touch it!

sonarqubecloud · 2021-06-07T15:11:56Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
5 Security Hotspots
35 Code Smells

0.0% Coverage
18.8% Duplication

manusa · 2021-06-07T15:16:47Z

@manusa could you check why the Karaf test failed? I swear I didn't touch it!

Those are flaky. We'll need to look into them, but for some reason there are timeouts when starting the platform.

matthyx · 2021-06-07T19:17:25Z

@manusa could you check why the Karaf test failed? I swear I didn't touch it!

Those are flaky. We'll need to look into them, but for some reason there are timeouts when starting the platform.

So I think we should merge this PR quickly until we need another headache rebase...

manusa

LGTM, thx!

rohanKanojia added the wip label Mar 18, 2021

rohanKanojia force-pushed the cert-manager branch 2 times, most recently from ddc33f2 to d35e958 Compare March 18, 2021 18:59

matthyx commented Mar 18, 2021

View reviewed changes

rohanKanojia changed the title ~~WIP add cert-manager support~~ WIP add cert-manager extension support Mar 18, 2021

rohanKanojia force-pushed the cert-manager branch from f00229b to cf50243 Compare March 18, 2021 20:50

rohanKanojia assigned matthyx Mar 18, 2021

matthyx force-pushed the cert-manager branch from 23f064e to 72aa60d Compare March 19, 2021 14:01

matthyx force-pushed the cert-manager branch 2 times, most recently from af24f83 to 0fa0504 Compare March 22, 2021 15:16

rohanKanojia removed the wip label Apr 5, 2021

rohanKanojia mentioned this pull request May 17, 2021

Is there any plan to support the API for openkruise？ #3117

Closed

manusa force-pushed the cert-manager branch 2 times, most recently from 448699b to 193c8cd Compare May 20, 2021 08:12

matthyx force-pushed the cert-manager branch 3 times, most recently from 7842159 to 38f562d Compare May 25, 2021 14:04

matthyx force-pushed the cert-manager branch from 38f562d to 1aa2cb0 Compare June 7, 2021 07:13

matthyx force-pushed the cert-manager branch from 1aa2cb0 to f83207d Compare June 7, 2021 13:05

Fix fabric8io#2565: add cert-manager support

55c30f6

matthyx force-pushed the cert-manager branch from f83207d to 55c30f6 Compare June 7, 2021 14:39

manusa approved these changes Jun 8, 2021

View reviewed changes

manusa merged commit f64554c into fabric8io:master Jun 8, 2021

matthyx deleted the cert-manager branch June 8, 2021 05:09

manusa added this to the 5.5.0 milestone Jun 8, 2021

rohanKanojia mentioned this pull request Jun 14, 2021

Create Fabric8 Prometheus Extension #2915

Closed

vsevel mentioned this pull request Jul 14, 2021

Increased compilation times with GraalVM 21.1.0 quarkusio/quarkus#18360

Closed

Add cert-manager extension support #2930

Add cert-manager extension support #2930

Conversation

matthyx commented Mar 18, 2021 • edited Loading

Description

Type of change

Checklist

centos-ci commented Mar 18, 2021

matthyx commented Mar 18, 2021

matthyx commented Mar 18, 2021

rohanKanojia commented Mar 18, 2021

matthyx commented Mar 18, 2021

matthyx commented Mar 18, 2021

matthyx commented Mar 18, 2021

matthyx left a comment

Choose a reason for hiding this comment

matthyx Mar 18, 2021

Choose a reason for hiding this comment

matthyx Mar 18, 2021

Choose a reason for hiding this comment

rohanKanojia Mar 18, 2021

Choose a reason for hiding this comment

rohanKanojia commented Mar 18, 2021

rohanKanojia commented Mar 18, 2021

matthyx commented Mar 18, 2021

rohanKanojia commented Mar 18, 2021 • edited Loading

matthyx commented Mar 18, 2021

matthyx commented Mar 18, 2021

matthyx commented Mar 19, 2021

matthyx commented Mar 25, 2021

rohanKanojia commented Mar 29, 2021

rohanKanojia commented Apr 16, 2021

matthyx commented Apr 16, 2021

rohanKanojia commented Apr 16, 2021 • edited Loading

vsevel commented Apr 30, 2021

matthyx commented May 25, 2021

manusa commented May 25, 2021

matthyx commented May 25, 2021

irbekrm commented Jun 7, 2021

matthyx commented Jun 7, 2021

manusa commented Jun 7, 2021

matthyx commented Jun 7, 2021

manusa commented Jun 7, 2021

matthyx commented Jun 7, 2021

matthyx commented Jun 7, 2021

sonarqubecloud bot commented Jun 7, 2021

manusa commented Jun 7, 2021

matthyx commented Jun 7, 2021

manusa left a comment

Choose a reason for hiding this comment

matthyx commented Mar 18, 2021 •

edited

Loading

rohanKanojia commented Mar 18, 2021 •

edited

Loading

rohanKanojia commented Apr 16, 2021 •

edited

Loading