-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not repeatly create Config in exec #1081
Conversation
Can you please create an issue for this and add a line in CHANGELOG? |
ok to test |
ok to test |
Sure. I get the CHANGELOG part. But why is an issue needed? |
To track what you're doing. This project need to track any change/update we do, because in the past we broke things also for minor stuff like this. |
I see. The issue is here #1082 . |
Thanks a lot :-) |
Please update the PR with the changes in CHANGELOG.md because that is the file we track 😃 |
Done. |
Man these tests are utterly time consuming... |
Sorry to say, but you need to squash the commits into one also. We have complete guidelines here https://github.com/fabric8io/kubernetes-client/blob/master/CONTRIBUTING.md |
The regression failure is caused by timeout. Doesn't seem to relate to this PR. |
Looks good. |
[merge] |
Thanks everyone. We would love to see this be shipped soon. |
Hey @skyline75489 Kubernetes Client 3.2.0 released which have this fix |
Thanks for the heads up 👍 |
This fixes #1082