Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HasMetadata should provide utility method to deal with owner references #3600

Closed
metacosm opened this issue Nov 16, 2021 · 0 comments · Fixed by #3601
Closed

HasMetadata should provide utility method to deal with owner references #3600

metacosm opened this issue Nov 16, 2021 · 0 comments · Fixed by #3601
Assignees
@metacosm
Labels
enhancement

Comments

@metacosm
Copy link
Collaborator

In particular to create and add owner references directly from another HasMetadata object.
@metacosm metacosm self-assigned this Nov 16, 2021
metacosm added a commit that referenced this issue Nov 16, 2021
@metacosm
feat: add owner reference support to HasMetadata
d58b6c9 
Fixes #3600
metacosm added a commit that referenced this issue Nov 16, 2021
@metacosm
feat: add owner reference support to HasMetadata
13cec39 
Fixes #3600
@metacosm metacosm mentioned this issue Nov 16, 2021
Merged
11 tasks
@snowdrop-bot snowdrop-bot mentioned this issue Nov 16, 2021
Open
@shawkins shawkins mentioned this issue Nov 30, 2021
Closed
manusa pushed a commit that referenced this issue Dec 16, 2021
@metacosm
feat: add owner reference support to HasMetadata (#3601)
e63e276 
* feat: add owner reference support to HasMetadata

Fixes #3600

* fix: shield against potentially `null` metadata and owner references

* fix: ignore "false" getter

* feat: extract `sanitizeAndValidate` method, add javadoc

* fix: `addOwnerReference(HasMetadata)` should validate created reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metacosm metacosm

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add owner reference support to HasMetadata fabric8io/kubernetes-client
1 participant
@metacosm