This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
Fix ImageChange triggers not being set in DeploymentConfig when resource fragments are used. #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rce fragments are used. Related StackOverlow post: https://stackoverflow.com/questions/60375063 This seems to be a regression since we introduced sidecar containers support. For applying ImageChange triggers we have to check which containers are main application containers and which are sidecars. Well, we do that but when we don't set any `defaultApplicationContainerName` when sidecar option is disabled. It seemed like a bug introduced my me during implementation.
rohanKanojia
force-pushed
the
pr/fix-imagetriggertagbug
branch
from
00a6ea9 to
5213077
Compare
oscerd
approved these changes
Feb 28, 2020
manusa
approved these changes
Mar 2, 2020
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this pull request
Mar 6, 2020
…rce fragments are used. Ported PR from FMP fabric8io/fabric8-maven-plugin#1794
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this pull request
Mar 9, 2020
…rce fragments are used. Ported PR from FMP fabric8io/fabric8-maven-plugin#1794
manusa
pushed a commit
to eclipse-jkube/jkube
that referenced
this pull request
Mar 9, 2020
…rce fragments are used. Ported PR from FMP fabric8io/fabric8-maven-plugin#1794
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related StackOverlow post: https://stackoverflow.com/questions/60375063
This seems to be a regression since we introduced sidecar containers support. For applying
ImageChange triggers we have to check which containers are main application containers and
which are sidecars. Well, we do that but when we don't set any
defaultApplicationContainerNamewhen the sidecar option is disabled. It seemed like a bug introduced me during implementation.
Sample project for testing: https://github.com/r0haaaan/fmp-openshift-sample-with-fragments
If you test on master, you can see in generated resources that
ImageChangetriggers are not being applied. But on this patch, they are being applied correctly.