This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 202
Fix #1770: Provide support for setting BuildConfig memory/CPU requests and limits #1772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Jan 3, 2020
rohanKanojia
force-pushed
the
pr/issue1770
branch
from
January 3, 2020 14:23
be7cb96
to
12d615e
Compare
devang-gaur
approved these changes
Jan 6, 2020
this.requests = requests; | ||
} | ||
|
||
private Map<String, String> requests; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a serious change request but can you group the class properties together and the functions together?
devang-gaur
suggested changes
Jan 6, 2020
|
||
if (specBuilder.buildSource() == null) { | ||
specBuilder.withNewSource() | ||
.withType("Binary") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you eliminate the hard coding here and all the places where SourceType property is used?
…U requests and limits
rohanKanojia
force-pushed
the
pr/issue1770
branch
from
January 6, 2020 12:00
12d615e
to
0aecc82
Compare
devang-gaur
approved these changes
Jan 8, 2020
manusa
approved these changes
Jan 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rohanKanojia
added
jkube/pending
The issue/PR has to be taken care of in JKube https://github.com/eclipse/jkube
target/JKube
Implementation to be performed in JKube
and removed
jkube/pending
The issue/PR has to be taken care of in JKube https://github.com/eclipse/jkube
labels
Jan 14, 2020
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this pull request
Mar 6, 2020
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this pull request
Mar 9, 2020
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this pull request
Mar 9, 2020
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this pull request
Mar 9, 2020
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this pull request
Mar 9, 2020
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this pull request
Mar 16, 2020
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this pull request
Mar 17, 2020
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this pull request
Mar 26, 2020
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this pull request
Mar 26, 2020
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this pull request
Mar 26, 2020
manusa
pushed a commit
to eclipse-jkube/jkube
that referenced
this pull request
Mar 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1770
This PR provides the support of configuring BuildConfig's spec using xml config or as a resource fragment. You can have xml config like this: